Bug 1329979

Summary: MultiHost Setup Networks command is not working
Product: [oVirt] ovirt-engine Reporter: Michael Burman <mburman>
Component: BLL.NetworkAssignee: Roman Mohr <rmohr>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.0.0CC: bugs, danken
Target Milestone: ovirt-4.0.0-alphaKeywords: Regression
Target Release: 4.0.0Flags: rule-engine: ovirt-4.0.0+
rule-engine: blocker+
rule-engine: planning_ack+
danken: devel_ack+
myakove: testing_ack+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.0.0_beta1~270 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-05 07:48:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
engine log none

Description Michael Burman 2016-04-25 08:33:06 UTC
Created attachment 1150296 [details]
engine log

Description of problem:
Multi Host Setup Networks command is not working.
The functionality of the multiHost setup networks command, seems to stop working at all. 

Changes over a network that is attached to host are not applied at all and there is no setup networks command sent. 

Examples: 
Changing vm/non-vm
vlan/non vlan
Adding new Host QoS 
In all this changes network become out-of-sync with the host and no setup networks command is sent or changes applied. 
 
Version-Release number of selected component (if applicable):
4.0.0-0.0.master.20160423161403.gite38df80.el7.centos

How reproducible:
100

Steps to Reproduce:
1. Attach network to host via setup networks
2. Try to change via the Networks main tab :
from VM network to non-VM
from non-vlan to vlan
Add new Host QoS

Actual results:
Network is out-of-sync
Changes are not applied on the host and no setup networks command is being send.

Expected results:
Should work as expected.

Comment 1 Alona Kaplan 2016-04-25 12:05:07 UTC
The bug is that NestedCommandFactory.createWrappedCommand(..) doesn't do 'command.setInternalExecution(isInternal);'

So the command is not marked as internal. This causes the permissions of the command to be validated, which is wrong since we shouldn't verify permissions of internal command.

Comment 2 Red Hat Bugzilla Rules Engine 2016-04-26 11:38:37 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 3 Martin Perina 2016-05-03 07:20:52 UTC
*** Bug 1332100 has been marked as a duplicate of this bug. ***

Comment 4 Michael Burman 2016-05-25 12:18:48 UTC
Verified on -  4.0.0-0.0.master.20160524171531.gitfba61e9.el7.centos and 
vdsm-4.18.0-43.git6f7fc83.el7.centos.x86_64

Comment 5 Sandro Bonazzola 2016-07-05 07:48:00 UTC
oVirt 4.0.0 has been released, closing current release.