Bug 1330673

Summary: Strings do not get branded without changing the PO files
Product: Red Hat Satellite Reporter: Shimon Shtein <sshtein>
Component: BrandingAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: jcallaha
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bbuckingham, bkearney, cwelton, ehelms, sshtein, sthirugn
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-foreman_theme_satellite-0.1.15-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-27 11:02:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Shimon Shtein 2016-04-26 17:11:11 UTC
Description of problem:

Currently the build process gets very complicated. It assumes running a special task each time strings are added to upstream.


Steps to Reproduce:
1. Take a new version from upstream with new branded strings
2. Package foreman
3. Observe new strings don't get branded.

Comment 3 Shimon Shtein 2016-05-29 07:55:38 UTC
I wouldn't call that easy, but there's a way to do it by messing a bit with required gems and documentation:

1. Run 'foreman-rake apipie:cache' it should generate new documentation
2. Go to documentation for V2, look for PUT "/discovered_hosts/:id/" description
3. The description for ip parameter will state "not required if using a subnet with DHCP capsule" as it should

4. Remove dependency on foreman_theme_satellite

5. Run 'foreman-rake apipie:cache' it should generate new documentation
6. Go to documentation for V2, look for PUT "/discovered_hosts/:id/" description
7. The description for ip parameter will state "not required if using a subnet with DHCP proxy" instead of "...DHCP capsule"

Another string that I found that is not branded in PO (and needs on the fly branding) is an error message when refreshing facts:

1. Use discovery to discover a new host (any host)
2. Shut down the proxy (capsule) that is responsible for discovery
3. Refresh the facts for the host
4. Should show an exception that starts with "Could not get facts from capsule..."

5. remove dependency on foreman_theme_satellite

6. Refresh the facts for the host
7. Should show an exception that starts with "Could not get facts from proxy..." instead of "capsule"

Comment 7 jcallaha 2016-06-17 15:50:33 UTC
Dev task, marking as Verified.

Comment 8 Bryan Kearney 2016-07-27 11:02:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1501