Bug 1330856

Summary: Review Request: numix-gtk-theme - Numix Gtk Theme
Product: [Fedora] Fedora Reporter: Sascha Spreitzer (Red Hat) <sspreitz>
Component: Package ReviewAssignee: Simone Caronni <negativo17>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review
Target Milestone: ---Flags: negativo17: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-21 17:30:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Sascha Spreitzer (Red Hat) 2016-04-27 07:08:07 UTC 
Spec URL: https://raw.githubusercontent.com/sspreitzer/numix-specs/development/numix-gtk-theme.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2104/13812104/numix-icon-theme-0.1.0-8.git101307f.fc23.src.rpm
Description: Numix is a modern flat theme with a combination of light and dark elements. It supports Gnome, Unity, XFCE and Openbox.
Fedora Account System Username: sspreitz
Comment 1 Sascha Spreitzer (Red Hat) 2016-04-27 07:11:55 UTC 
(In reply to Sascha Spreitzer from comment #0)
> SRPM URL:
> https://kojipkgs.fedoraproject.org//work/tasks/2104/13812104/numix-icon-
> theme-0.1.0-8.git101307f.fc23.src.rpm

was wrong srpm

SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2050/13812050/numix-gtk-theme-2.5.1-2.gitbde0a73.fc23.src.rpm
Comment 2 Sascha Spreitzer (Red Hat) 2016-04-27 07:16:02 UTC 
*** Bug 1327828 has been marked as a duplicate of this bug. ***
Comment 3 Simone Caronni 2016-04-30 01:16:54 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Dist tag is present.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 18 files have unknown license. Detailed
     output of licensecheck in /home/slaanesh/1330856-numix-gtk-
     theme/licensecheck.txt
[-]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Comment 4 Simone Caronni 2016-04-30 01:18:31 UTC 
Rpmlint
-------
Checking: numix-gtk-theme-2.5.1-2.gitbde0a73.fc23.noarch.rpm
          numix-gtk-theme-2.5.1-2.gitbde0a73.fc23.src.rpm
numix-gtk-theme.noarch: E: description-line-too-long C Numix is a modern flat theme with a combination of light and dark elements. It supports Gnome, Unity, XFCE and Openbox.
numix-gtk-theme.noarch: W: incoherent-version-in-changelog 2.5.1-2 ['2.5.1-2.gitbde0a73.fc23', '2.5.1-2.gitbde0a73']
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/stick-toggled-pressed.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/_widgets.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/_colors.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/hide-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/maximize-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/gtk.css
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/widgets/_base.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/title-4-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/_functions.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/maximize-toggled-prelight.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/widgets/_toolbar.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/widgets/_toggle.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/hide-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/stick-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/openbox-3/themerc
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-2.0/gtkrc
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/README.md
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/shade-toggled-pressed.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/widgets/_sidebar.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/title-3-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/widgets/_button.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/top-left-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/title-4-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/openbox-3/max.xbm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/menu-pressed.xpm
numix-gtk-theme.noarch: W: spurious-executable-perm /usr/share/doc/numix-gtk-theme/CREDITS
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/left-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/widgets/_window.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/stick-pressed.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/widgets/_entry.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/themerc
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/bottom-left-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/bottom-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/title-2-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/LICENSE
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/menu-prelight.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/left-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/close-pressed.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/maximize-toggled-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/title-2-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/menu-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/stick-prelight.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/maximize-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/title-1-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/openbox-3/shade.xbm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/maximize-prelight.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/shade-toggled-prelight.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/Makefile
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/maximize-toggled-pressed.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/widgets/_toolbar.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/bottom-right-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/hide-pressed.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/openbox-3/shade_toggled.xbm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/top-right-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/shade-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/openbox-3/desk.xbm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/shade-toggled-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/stick-toggled-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/CREDITS
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/shade-pressed.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/stick-toggled-prelight.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/stick-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/hide-prelight.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/_global.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/shade-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/_global.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/widgets/_entry.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/index.theme
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/title-5-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/openbox-3/desk_toggled.xbm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/widgets/_menu.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/openbox-3/iconify.xbm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/_functions.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/gtk-dark.css
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/right-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/top-left-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/menu-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/_widgets.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/_colors.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfce-notify-4.0/gtkrc
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/widgets/_toggle.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/bottom-right-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/close-prelight.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/widgets/_window.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/stick-toggled-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/licenses/numix-gtk-theme/LICENSE
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/bottom-inactive.xpm
numix-gtk-theme.noarch: W: spurious-executable-perm /usr/share/doc/numix-gtk-theme/README.md
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/shade-prelight.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/close-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/widgets/_sidebar.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/scss/widgets/_menu.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/close-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/maximize-toggled-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/openbox-3/close.xbm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/metacity-1/metacity-theme-2.xml
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/metacity-1/metacity-theme-3.xml
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/widgets/_button.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/maximize-pressed.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/top-right-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/scss/widgets/_base.scss
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.20/gtk-dark.css
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/shade-toggled-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/bottom-left-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/gtk-3.0/gtk.css
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/right-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/title-5-active.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/title-1-inactive.xpm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/openbox-3/max_toggled.xbm
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/title-3-active.xpm
numix-gtk-theme.src: E: description-line-too-long C Numix is a modern flat theme with a combination of light and dark elements. It supports Gnome, Unity, XFCE and Openbox.
numix-gtk-theme.src: W: no-%build-section
2 packages and 0 specfiles checked; 110 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
numix-gtk-theme.noarch: E: description-line-too-long C Numix is a modern flat theme with a combination of light and dark elements. It supports Gnome, Unity, XFCE and Openbox.
numix-gtk-theme.noarch: W: incoherent-version-in-changelog 2.5.1-2 ['2.5.1-2.gitbde0a73.fc23', '2.5.1-2.gitbde0a73']
numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/metacity-1/metacity-theme-3.xml

[...snip...]

numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/CREDITS
1 packages and 0 specfiles checked; 109 errors, 3 warnings.



Requires
--------
numix-gtk-theme (rpmlib, GLIBC filtered):
    gtk-murrine-engine



Provides
--------
numix-gtk-theme:
    numix-gtk-theme



Source checksums
----------------
https://github.com/numixproject/numix-gtk-theme/archive/bde0a7364864b0e3b8265c5b13969757295e1e17.tar.gz#/numix-gtk-theme-bde0a73.tar.gz :
  CHECKSUM(SHA256) this package     : 39798faa5c6298545e4dce7d86e034947d2c02b6403bd39a81d5b820a52eac95
  CHECKSUM(SHA256) upstream package : 39798faa5c6298545e4dce7d86e034947d2c02b6403bd39a81d5b820a52eac95


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1330856
Buildroot used: fedora-23-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comment 5 Simone Caronni 2016-04-30 01:49:26 UTC 
> [!]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses
>     found: "Unknown or generated". 18 files have unknown license. Detailed
>     output of licensecheck in /home/slaanesh/1330856-numix-gtk-
>     theme/licensecheck.txt

That's ok, you can ignore it, as long as it's not showing different icons.

> [!]: Changelog in prescribed format.
> numix-gtk-theme.noarch: W: incoherent-version-in-changelog 2.5.1-2 ['2.5.1-2.gitbde0a73.fc23', '2.5.1-2.gitbde0a73']

You should have exactly the same name-version-release tags in the changelog as the package that you are generating. That is, in this case: 2.5.1-2.gitbde0a73

Please note that actually (next time) when you update the spec file with "rpmdev-bumpspec" it will actually put the correct tag in the changelog as required.

> [!]: Requires correct, justified where necessary.

The directory %{_datadir}/themes is not owned by your package, please add "filesystem" as requirement. It's always installed, but better be safe than sorry.

$ rpm -qf /usr/share/themes/
filesystem-3.2-37.fc24.x86_64

> numix-gtk-theme.noarch: E: description-line-too-long C Numix is a modern flat theme with a combination of light and dark elements. It supports Gnome, Unity, XFCE and Openbox.

Plase open the text file with an editor and make sure that you have descriptions cut at 80 columns. As obvious you don't need to have exactly 80 columns but you can just cut before reaching the amount.

> numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/stick-toggled-pressed.xpm

All the files that are under /usr/share/themes should not be executable. Please run something like this after the %make_install macro:

find %{buildroot} -name "*.xml" -exec chmod 644 {} \;

Or better fix the Makefile. At the end rpmlint should return no "script-without-shebang" or "spurious-executable-perm".
Comment 6 Simone Caronni 2016-04-30 03:04:11 UTC 
If you're not planning to support RHEL 6 please remove the "Group:" tag (not required but not mandatory to be removed).
Comment 7 Simone Caronni 2016-05-02 12:36:44 UTC 
> Issues:
> =======
> - Dist tag is present.

Please use "%{?dist}" in place of "%{dist}" in the Release field.
Comment 8 Simone Caronni 2016-05-02 13:03:29 UTC 
You can also replace some more "numix-gtk-theme" with "%{name}" in the Source directives, but this is up to you.
Comment 9 Simone Caronni 2016-05-31 11:17:56 UTC 
Sponsoring user, no longer requiring a sponsor:

https://fedorahosted.org/packager-sponsors/ticket/275

Thanks to everyone involved.
Comment 10 Sascha Spreitzer (Red Hat) 2016-06-13 14:10:53 UTC 
Updates based on sponsor guidance

Spec URL: https://raw.githubusercontent.com/sspreitzer/numix-specs/development/numix-gtk-theme.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3072/14473072/numix-gtk-theme-2.5.1-4.gitbde0a73.fc25.src.rpm
Comment 11 Simone Caronni 2016-06-13 14:18:48 UTC 
All requests have been satisfied, package approved!
Comment 12 Gwyn Ciesla 2016-06-13 14:56:54 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/numix-gtk-theme