Bug 1330982

Summary: [RFE] Instance name validation for GCE provider
Product: Red Hat CloudForms Management Engine Reporter: Taras Lehinevych <tlehinev>
Component: UI - OPSAssignee: Adam Grare <agrare>
Status: CLOSED ERRATA QA Contact: Kyrylo Zvyagintsev <kzvyahin>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.6.0CC: agrare, dajohnso, hkataria, jhardy, kzvyahin, lkhomenk, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: FutureFeature
Target Release: 5.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: provider:google:validation
Fixed In Version: 5.7.0.0 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-04 12:54:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Taras Lehinevych 2016-04-27 11:50:47 UTC
Description of problem:
We are not allow to use underscore and upper case letter in instance name  for Google Compute Engine. Currently there is no validation for instance field and provisioning fails with message "[Fog::Errors::Error]: Invalid value for field 'resource.name': 'test-BZ-retire-api'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)' "

Version-Release number of selected component (if applicable):
5.6.0.4-beta2.3

How reproducible:
100%

Steps to Reproduce:
1. Add GCE provider and press Lifecycle -> Provision instances
2. Enter instance name with underscore or upper case letter and fill in other required fields
3. Press Submit

Actual results:
The provisioning request will be created

Expected results:
Error message that instance name doesn't match regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'

Additional info:

Comment 4 Greg McCullough 2016-08-08 13:44:33 UTC
*** Bug 1364931 has been marked as a duplicate of this bug. ***

Comment 6 CFME Bot 2016-08-15 14:36:29 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/3ebc6cd5626ddf9bcf5a347aeb28c116f48c6b44

commit 3ebc6cd5626ddf9bcf5a347aeb28c116f48c6b44
Author:     Joe Selman <jsselman>
AuthorDate: Mon Aug 8 14:48:58 2016 -0700
Commit:     Joe Selman <jsselman>
CommitDate: Tue Aug 9 12:33:07 2016 -0700

    Add a regex validation on vm name for Google provider
    
    Also enforced a min/max length. Fixes downstream bug
    https://bugzilla.redhat.com/show_bug.cgi?id=1330982

 .../miq_dialogs/miq_provision_google_dialogs_template.yaml   | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comment 10 errata-xmlrpc 2017-01-04 12:54:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0012.html