Bug 1331016

Summary: restoring files scope needs --restore-permissions/--no-restore-permissions
Product: [oVirt] ovirt-engine Reporter: Jiri Belka <jbelka>
Component: Backup-Restore.EngineAssignee: Yedidyah Bar David <didi>
Status: CLOSED WONTFIX QA Contact: Aleksei Slaikovskii <aslaikov>
Severity: low Docs Contact:
Priority: medium    
Version: 4.0.0CC: bugs, sbonazzo, vpagar, ylavi
Target Milestone: ---Keywords: EasyFix
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-25 07:29:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1371658    

Description Jiri Belka 2016-04-27 13:02:25 UTC 
Description of problem:

the following does not make sense for me as it is related to pg_dump

# engine-backup --mode=restore --scope=files --file=backup --log=restore_files.log 
Preparing to restore:
- Unpacking file 'backup'
FATAL: Please pass one of --restore-permissions or --no-restore-permissions when restoring a backup with a custom dump format


Version-Release number of selected component (if applicable):
ovirt-engine-tools-backup-4.0.0-0.0.master.20160427051413.git340728a.el7.centos.noarch

How reproducible:
100%

Steps to Reproduce:
1. run the command above
2.
3.

Actual results:
requires unrelated option to files' scope

Expected results:
the command above should pass / files scope does not need any PG related option

Additional info:
Comment 1 Yaniv Lavi 2016-05-23 13:16:02 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 2 Yaniv Lavi 2016-05-23 13:19:53 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 3 Yaniv Lavi 2016-06-02 08:29:08 UTC 
We added a help for these flags, please test that this is resolved.
Comment 4 Yedidyah Bar David 2016-06-02 09:37:59 UTC 
It's a real bug. It's not related to the bug about --help.

Restoring files should not require one of these options but it currently does.
Comment 6 Yaniv Lavi 2017-02-06 10:54:09 UTC 
*** Bug 1371658 has been marked as a duplicate of this bug. ***
Comment 7 Yaniv Lavi 2018-06-25 07:29:04 UTC 
Closing old bugs.
Please reopen if still relevant.
Patches are welcomed.