| Summary: | UI: Instance reconfigure broken in cloud providers | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Satyajit Bulage <sbulage> |
| Component: | UI - OPS | Assignee: | Milan Zázrivec <mzazrivec> |
| Status: | CLOSED ERRATA | QA Contact: | Satyajit Bulage <sbulage> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.6.0 | CC: | hkataria, jhardy, mpovolny, obarenbo, simaishi |
| Target Milestone: | GA | ||
| Target Release: | 5.6.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | vm:reconfigure | ||
| Fixed In Version: | 5.6.0.6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-06-29 15:55:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/90181a13c4cca3191c80c1141fe4886b7b80681f commit 90181a13c4cca3191c80c1141fe4886b7b80681f Author: Milan Zazrivec <mzazrivec> AuthorDate: Thu Apr 28 11:53:11 2016 +0200 Commit: Milan Zazrivec <mzazrivec> CommitDate: Thu Apr 28 11:53:11 2016 +0200 Fix traceback in instance reconfigure screen when nil size root disk Some instances (Amazon) do not seem to have the info about root disk size available. Fixing the following error: Error caught: [NoMethodError] undefined method `bytes' for nil:NilClass app/models/flavor.rb:36:in `name_with_details' app/views/vm_common/_resize.html.haml:13 https://bugzilla.redhat.com/show_bug.cgi?id=1331052 app/controllers/vm_common.rb | 2 +- app/models/flavor.rb | 14 +++++++++++--- 2 files changed, 12 insertions(+), 4 deletions(-) There are several problems showing here:
1. error showing when root disk size collected during provider refresh
is nil / null (the initial problem of this bug report):
https://github.com/ManageIQ/manageiq/pull/8308
2. error showing when the instance reconfigure form is cancelled or submitted:
https://github.com/ManageIQ/manageiq/pull/8310
3. the instance reconfigure button should not be visible for other than
OpenStack instances:
https://github.com/ManageIQ/manageiq/pull/8319
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/e0e6904a6ca59e371e1cff8aa89c688ff94ec02c commit e0e6904a6ca59e371e1cff8aa89c688ff94ec02c Author: Milan Zazrivec <mzazrivec> AuthorDate: Thu Apr 28 13:39:04 2016 +0200 Commit: Milan Zazrivec <mzazrivec> CommitDate: Thu Apr 28 16:25:33 2016 +0200 Fix resize_vm() cancel and submission errors This is to fix the following error when submiting / canceling vm resize: Error caught: [NoMethodError] undefined method `[]' for nil:NilClass app/controllers/vm_cloud_controller.rb:41:in `resize_vm' https://bugzilla.redhat.com/show_bug.cgi?id=1331052 app/controllers/vm_cloud_controller.rb | 3 ++- spec/controllers/vm_cloud_controller_spec.rb | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) *** Bug 1328702 has been marked as a duplicate of this bug. *** New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/1c6c0cd7d5589c89bbf1716c9362ff91d3ec8f8f commit 1c6c0cd7d5589c89bbf1716c9362ff91d3ec8f8f Author: Milan Zazrivec <mzazrivec> AuthorDate: Thu Apr 28 16:11:03 2016 +0200 Commit: Milan Zazrivec <mzazrivec> CommitDate: Wed May 4 10:15:19 2016 +0200 Fix instance reconfigure button visibility The 'Reconfigure this Instance' toolbar button should only be visible if the model supports the operation. https://bugzilla.redhat.com/show_bug.cgi?id=1331052 app/controllers/vm_cloud_controller.rb | 6 +++--- app/helpers/application_helper/button/instance_reconfigure.rb | 10 ++++++++++ .../application_helper/toolbar/openstack_vm_cloud_center.rb | 3 ++- app/helpers/application_helper/toolbar/x_vm_cloud_center.rb | 3 ++- app/models/manageiq/providers/cloud_manager/vm.rb | 4 ++++ .../manageiq/providers/openstack/cloud_manager/vm/resize.rb | 5 ++++- .../manageiq/providers/openstack/cloud_manager/vm_spec.rb | 6 +++--- 7 files changed, 28 insertions(+), 9 deletions(-) create mode 100644 app/helpers/application_helper/button/instance_reconfigure.rb Able to display "Reconfiguration" form for selected Instance. Verified Version: 5.6.0.6-beta2.5.20160511140943_ff75fb2 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1348 |
Description of problem: While opening instance for reconfiguration, selected Instance screen flicks and back to it's original state doesn't show Reconfiguration form. Version-Release number of selected component (if applicable): 5.6.0.4-beta2.3.20160421172650_719e256 How reproducible: 100% Steps to Reproduce: 1. Navigate to Compute --> Clouds --> Instances 2. Select any Instance and Navigate to Configuration --> Reconfigure Selected Instance Actual results: Spinner just rotates and no form is displayed. Also error thrown in production log. Expected results: It should display "Reconfiguration" form for selected Instance. Additional info: Production Logs: [----] I, [2016-04-27T10:30:41.300031 #27566:d33ec0] INFO -- : Started POST "/vm_cloud/x_button?pressed=instance_resize" for 127.0.0.1 at 2016-04-27 10:30:41 -0400 [----] I, [2016-04-27T10:30:41.302088 #27566:d33ec0] INFO -- : Processing by VmCloudController#x_button as JS [----] I, [2016-04-27T10:30:41.302215 #27566:d33ec0] INFO -- : Parameters: {"miq_grid_checks"=>"466", "pressed"=>"instance_resize"} [----] W, [2016-04-27T10:30:41.304640 #27566:d33ec0] WARN -- : Can't verify CSRF token authenticity. [----] F, [2016-04-27T10:30:41.305345 #27566:d33ec0] FATAL -- : Error caught: [ActionController::InvalidAuthenticityToken] ActionController::InvalidAuthenticityToken /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_controller/metal/request_forgery_protection.rb:195:in `handle_unverified_request' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_controller/metal/request_forgery_protection.rb:223:in `handle_unverified_request' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_controller/metal/request_forgery_protection.rb:218:in `verify_authenticity_token' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:382:in `block in make_lambda' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:150:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:150:in `block (2 levels) in halting_and_conditional' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/abstract_controller/callbacks.rb:12:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/abstract_controller/callbacks.rb:12:in `block (2 levels) in <module:Callbacks>' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:151:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:151:in `block in halting_and_conditional' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:454:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:454:in `block in call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:454:in `each' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:454:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:101:in `__run_callbacks__' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:750:in `_run_process_action_callbacks' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:90:in `run_callbacks' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/abstract_controller/callbacks.rb:19:in `process_action' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_controller/metal/rescue.rb:31:in `process_action' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/notifications.rb:164:in `block in instrument' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/notifications/instrumenter.rb:21:in `instrument' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/notifications.rb:164:in `instrument' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_controller/metal/instrumentation.rb:30:in `process_action' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_controller/metal/params_wrapper.rb:248:in `process_action' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activerecord/lib/active_record/railties/controller_runtime.rb:18:in `process_action' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/abstract_controller/base.rb:126:in `process' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionview/lib/action_view/rendering.rb:30:in `process' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_controller/metal.rb:190:in `dispatch' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_controller/metal.rb:262:in `dispatch' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/routing/route_set.rb:50:in `dispatch' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/routing/route_set.rb:32:in `serve' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/journey/router.rb:39:in `block in serve' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/journey/router.rb:26:in `each' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/journey/router.rb:26:in `serve' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/routing/route_set.rb:739:in `call' /opt/rh/cfme-gemset/gems/omniauth-1.3.1/lib/omniauth/strategy.rb:186:in `call!' /opt/rh/cfme-gemset/gems/omniauth-1.3.1/lib/omniauth/strategy.rb:164:in `call' /opt/rh/cfme-gemset/gems/omniauth-1.3.1/lib/omniauth/builder.rb:63:in `call' /opt/rh/cfme-gemset/gems/secure_headers-3.0.3/lib/secure_headers/middleware.rb:10:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.0.alpha/lib/rack/etag.rb:25:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.0.alpha/lib/rack/conditional_get.rb:38:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.0.alpha/lib/rack/head.rb:12:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.0.alpha/lib/rack/session/abstract/id.rb:220:in `context' /opt/rh/cfme-gemset/gems/rack-2.0.0.alpha/lib/rack/session/abstract/id.rb:214:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/middleware/cookies.rb:613:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/middleware/callbacks.rb:38:in `block in call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:97:in `__run_callbacks__' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:750:in `_run_call_callbacks' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/callbacks.rb:90:in `run_callbacks' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/middleware/callbacks.rb:36:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/middleware/remote_ip.rb:79:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/railties/lib/rails/rack/logger.rb:36:in `call_app' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/railties/lib/rails/rack/logger.rb:26:in `call' /opt/rh/cfme-gemset/gems/request_store-1.3.1/lib/request_store/middleware.rb:9:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/middleware/request_id.rb:24:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.0.alpha/lib/rack/method_override.rb:22:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.0.alpha/lib/rack/runtime.rb:22:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/activesupport/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/actionpack/lib/action_dispatch/middleware/executor.rb:12:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.0.alpha/lib/rack/sendfile.rb:111:in `call' /opt/rh/cfme-gemset/bundler/gems/rails-f0a2edc7fc08/railties/lib/rails/engine.rb:522:in `call' /opt/rh/rh-ruby22/root/usr/share/gems/gems/puma-3.3.0/lib/puma/configuration.rb:224:in `call' /opt/rh/rh-ruby22/root/usr/share/gems/gems/puma-3.3.0/lib/puma/server.rb:561:in `handle_request' /opt/rh/rh-ruby22/root/usr/share/gems/gems/puma-3.3.0/lib/puma/server.rb:406:in `process_client' /opt/rh/rh-ruby22/root/usr/share/gems/gems/puma-3.3.0/lib/puma/server.rb:271:in `block in run' /opt/rh/rh-ruby22/root/usr/share/gems/gems/puma-3.3.0/lib/puma/thread_pool.rb:111:in `call' /opt/rh/rh-ruby22/root/usr/share/gems/gems/puma-3.3.0/lib/puma/thread_pool.rb:111:in `block in spawn_thread' [----] I, [2016-04-27T10:30:41.307386 #27566:d33ec0] INFO -- : Rendered layouts/_exception_contents.html.haml (0.4ms) [----] I, [2016-04-27T10:30:41.308428 #27566:d33ec0] INFO -- : Completed 200 OK in 6ms (Views: 2.1ms | ActiveRecord: 0.0ms)