Bug 1331215

Summary: tmp_config undefined in databases/mysql/configuration_changes
Product: Red Hat Enterprise Linux 6 Reporter: Alois Mahdal <amahdal>
Component: preupgrade-assistant-el6toel7Assignee: Petr Stodulka <pstodulk>
Status: CLOSED ERRATA QA Contact: Alois Mahdal <amahdal>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.8CC: jmazanek, ovasik
Target Milestone: rcKeywords: Extras
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: preupgrade-assistant-el6toel7-0.6.48-1.el6 Doc Type: Bug Fix
Doc Text:
Do not document.
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-11 08:28:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Alois Mahdal 2016-04-28 02:46:38 UTC
Description of problem
======================

databases/mysql/configuration_changes prints following messages to stderr:


    INPLACERISK: MEDIUM: /etc/my.cnf: option 'plugin-load=innodb=' is not supported
    INPLACERISK: HIGH: /etc/my.cnf: option 'innodb_file_io_threads' is not supported
    INPLACERISK: HIGH: /etc/my.cnf: option 'language' is deprecated
    /root/preupgrade/RHEL6_7/databases/mysql/configuration_changes/configuration.sh: line 103: : No such file or directory
    INPLACERISK: HIGH: /etc/my.cnf: option 'log-bin-trust-routine-creators' was removed in MariaDB 5.5
    /root/preupgrade/RHEL6_7/databases/mysql/configuration_changes/configuration.sh: line 103: : No such file or directory
    INPLACERISK: HIGH: /etc/my.cnf: option 'table_lock_wait_timeout' was removed in MariaDB 5.5

where 103 refers to 83 in the source:

    echo "obsolete_options_used" >> "$tmp_config"

Indeed, tmp_config has not been defined.


Version-Release number of selected component
============================================

preupgrade-assistant-el6toel7-0.6.46-1.el6


How reproducible
================

Always (with relevant options in my.cnf)


Steps to Reproduce
==================

Schedule /CoreOS/preupgrade-assistant/6to7/contents/mysql-configuration_changes
and pay attention to sub-tests:

    table_lock_wait_timeout
    log_bin_trust_routine_creators
    AllOpts

 -or-

with mysql and mysql-libs installed, add one or both of following lines
to /etc/my.cnf under `[mysqld]` section:

    log-bin-trust-routine-creators=foo
    table_lock_wait_timeout=10

and run preupg.


Actual results
==============

Mentioned errors appear in module's stdout (if BZ#1309491 still applies;
else in stderr).  Module probably does not provide all necessary details.


Expected results
================

No errors; module gives all necessary details.

Comment 5 Alois Mahdal 2016-04-29 02:24:57 UTC
Sorry, the patch did not make it into build:

    [0 root@qeos-158 ~]# rpm -qa preupgrade\*
    preupgrade-assistant-2.1.6-4.el6.noarch
    preupgrade-assistant-ui-2.1.6-4.el6.noarch
    preupgrade-assistant-tools-2.1.6-4.el6.noarch
    preupgrade-assistant-CoreOS-preupgrade-assistant-Library-main-1.2-10.noarch
    preupgrade-assistant-el6toel7-data-0.20160406-1.el6.noarch
    preupgrade-assistant-el6toel7-0.6.47-1.el6.noarch
    [0 root@qeos-158 ~]# grep -w tmp_config /usr/share/preupgrade/RHEL6_7/databases/mysql/configuration_changes/configuration.sh
                echo "obsolete_options_used" >> "$tmp_config"
    [0 root@qeos-158 ~]#

Comment 8 Alois Mahdal 2016-04-29 20:16:29 UTC
Tested on all archs with  preupgrade-assistant-el6toel7-0.6.48-1.el6.

(In reply to Alois Mahdal from comment #0)
[...]
>
> Actual results
> ==============
> 
> Mentioned errors appear in module's stdout (if BZ#1309491 still applies;
> else in stderr).  Module probably does not provide all necessary details.
>
>
>
> Expected results
> ================
> 
> No errors; module gives all necessary details.


The error messages went away, though.

All details are (and were) and provided; my suspicion about missing details was wrong, as clarified with Petr.

Comment 9 errata-xmlrpc 2016-05-11 08:28:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1020.html