Bug 1331264

Summary:	libgfapi:Setting need_lookup on wrong list
Product:	[Community] GlusterFS	Reporter:	Mohammed Rafi KC <rkavunga>
Component:	libgfapi	Assignee:	Mohammed Rafi KC <rkavunga>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.11	CC:	bugs, rjoseph, sdharane
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1330476	Environment:
Last Closed:	2016-06-28 12:15:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1330476
Bug Blocks:

Description Mohammed Rafi KC 2016-04-28 07:21:27 UTC

+++ This bug was initially created as a clone of Bug #1330476 +++

Description of problem:

We are setting need_lookup on wrong list during readdirp cbk. we are using the previous list .
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-04-26 06:19:44 EDT ---

REVIEW: http://review.gluster.org/14073 (gfapi: set need_lookup flag on response list) posted (#1) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Vijay Bellur on 2016-04-26 11:36:34 EDT ---

REVIEW: http://review.gluster.org/14073 (gfapi: set need_lookup flag on response list) posted (#2) for review on master by Niels de Vos (ndevos)

--- Additional comment from Vijay Bellur on 2016-04-27 10:26:47 EDT ---

COMMIT: http://review.gluster.org/14073 committed in master by Niels de Vos (ndevos) 
------
commit 537557da59876536d33cd25a8ef485e7b5fe8849
Author: Mohammed Rafi KC <rkavunga>
Date:   Tue Apr 26 14:52:29 2016 +0530

    gfapi: set need_lookup flag on response list
    
    We set need_lookup flag for entries returned by readdirp
    to force lookup. Currently we are setting on the previously
    stored list, rather than response list returned by readdirp.
    
    This patch will iterate over current list returned by readdirp
    and will set need_lookup flag.
    
    Change-Id: Ibd6fcbc188f4c87f40ece7a9dcda27645401c240
    BUG: 1330476
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/14073
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 1 Vijay Bellur 2016-04-28 07:23:39 UTC

REVIEW: http://review.gluster.org/14098 (gfapi: set need_lookup flag on response list) posted (#1) for review on release-3.7 by mohammed rafi  kc (rkavunga)

Comment 2 Vijay Bellur 2016-05-24 05:47:10 UTC

COMMIT: http://review.gluster.org/14098 committed in release-3.7 by Rajesh Joseph (rjoseph) 
------
commit b45e2896eacb27b8a76729e9c460df5b5aa818a3
Author: Mohammed Rafi KC <rkavunga>
Date:   Tue Apr 26 14:52:29 2016 +0530

    gfapi: set need_lookup flag on response list
    
    We set need_lookup flag for entries returned by readdirp
    to force lookup. Currently we are setting on the previously
    stored list, rather than response list returned by readdirp.
    
    This patch will iterate over current list returned by readdirp
    and will set need_lookup flag.
    
    Back port of>
    >Change-Id: Ibd6fcbc188f4c87f40ece7a9dcda27645401c240
    >BUG: 1330476
    >Signed-off-by: Mohammed Rafi KC <rkavunga>
    >Reviewed-on: http://review.gluster.org/14073
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >Reviewed-by: Niels de Vos <ndevos>
    >Reviewed-by: Rajesh Joseph <rjoseph>
    >Smoke: Gluster Build System <jenkins.com>
    >CentOS-regression: Gluster Build System <jenkins.com>
    
    (cherry picked from commit 537557da59876536d33cd25a8ef485e7b5fe8849)
    
    
    Change-Id: If7bc0f58e5b8fb261625dc5067a6d330d508ebb1
    BUG: 1331264
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/14098
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Rajesh Joseph <rjoseph>

Comment 3 Kaushal 2016-06-28 12:15:37 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user