Bug 1331278

Summary: [RFE] Raise a meaningful error of the layout can not be created (i.e. no thinpool available)
Product: [oVirt] ovirt-node Reporter: Wei Wang <weiwang>
Component: RFEsAssignee: Douglas Schilling Landgraf <dougsland>
Status: CLOSED CURRENTRELEASE QA Contact: Qin Yuan <qiyuan>
Severity: high Docs Contact:
Priority: high    
Version: 4.0CC: bmcclain, bugs, cshao, dfediuck, dougsland, gklein, huzhao, leiwang, lsurette, mgoldboi, rbalakri, srevivo, yaniwang, ycui, ykaul
Target Milestone: ovirt-4.1.0-betaKeywords: FutureFeature
Target Release: 4.1Flags: rule-engine: ovirt-4.1+
bmcclain: priority_rfe_tracking+
cshao: testing_plan_complete+
mgoldboi: planning_ack+
fdeutsch: devel_ack+
ycui: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-01 14:46:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1140646    
Attachments:
Description Flags
kickstart file
none
log image1
none
log image2
none
log image3
none
log image4 none

Description Wei Wang 2016-04-28 07:57:34 UTC
Created attachment 1151769 [details]
kickstart file

Description of problem:
"'NoneType' object has no attribute 'addtag'" prompt during installation with kickstart file.

Version-Release number of selected component (if applicable):
rhev-hypervisor7-ng-3.6-20160426.0.x86_64
imgbased-0.6-0.1.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. Automatic install machine with kickstart file in attachment
   key kickstart script:
   part pv.01 --size=10000 --ondisk=/dev/sda
   part pv.02 --size=15000 --ondisk=/dev/sda
   part /boot --size=4300 --ondisk=/dev/sda
   volgroup testgroup pv.01 pv.02

   logvol / --vgname=testgroup --size=4300 --name=root
   logvol swap --vgname=testgroup --size=1024 --name=swap
   logvol /data --vgname=testgroup --size=4300 --name=data

   %post --erroronfail
   imgbase layout --init
   imgbase --experimental volume --create /var 1G
   %end
2. During installation, error prompt

Actual results:
During installation, error prompt

Expected results:
Automatic installation is successful, and imgbase is used on lvm


Additional info:

Comment 1 Wei Wang 2016-04-28 07:59:37 UTC
Created attachment 1151770 [details]
log image1

Comment 2 Wei Wang 2016-04-28 08:00:13 UTC
Created attachment 1151771 [details]
log image2

Comment 3 Wei Wang 2016-04-28 08:00:43 UTC
Created attachment 1151772 [details]
log image3

Comment 4 Wei Wang 2016-04-28 08:01:17 UTC
Created attachment 1151774 [details]
log image4

Comment 5 Fabian Deutsch 2016-04-28 08:45:38 UTC
It is required that you are creating an LVM setup with a thin pool.

Please re-test this.

I'll modify this bug, to enhance imgbased to raise a meaningful error.

Comment 6 Red Hat Bugzilla Rules Engine 2016-04-28 08:45:45 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 9 Red Hat Bugzilla Rules Engine 2016-09-22 10:18:20 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 10 Red Hat Bugzilla Rules Engine 2016-09-22 10:19:14 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 11 Qin Yuan 2016-12-27 09:47:25 UTC
Could you please attach the patch info, so that we could better understand the solution of this bug.

Comment 12 Qin Yuan 2017-01-11 10:26:01 UTC
Test Version:
redhat-virtualization-host-4.1-0.20170104.0
imgbased-0.9.2-0.1.el7ev.noarch

Test Steps:
1. Prepare kickstart file to install RHVH 4.1 in text mode, configure autopart --type=lvm
2. Install RHVH 4.1 with kickstart file generated in step1.

Test Results:
There is error message printed on the screen saying:
[ERROR] LVM Thin Provisioning partitioning scheme is required.
For autoinstall via Kickstart with LVM Thin Provisioning check options:
--thinpool and --growPlease consult documentation for details


There is friendly message when no thin pool in kickstart file, so change this RFE's status to VERIFIED.