Bug 1331319

Summary: The original logical partitions are not cleared after install with "--noformat" parameter in kickstart file.
Product: [oVirt] ovirt-node Reporter: Wei Wang <weiwang>
Component: Installation & UpdateAssignee: Fabian Deutsch <fdeutsch>
Status: CLOSED INSUFFICIENT_DATA QA Contact: Wei Wang <weiwang>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.0CC: bugs, cshao, fdeutsch, huzhao, leiwang, weiwang, yaniwang, ycui
Target Milestone: ovirt-4.1.0-alphaFlags: fdeutsch: ovirt-4.1?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-02 10:17:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
log file
none
kickstart file none

Description Wei Wang 2016-04-28 09:49:58 UTC
Created attachment 1151788 [details]
log file

Description of problem:
The original logical partitions are not cleared after install with "--noformat" parameter in kickstart file.

Version-Release number of selected component (if applicable):
rhev-hypervisor7-ng-3.6-20160426.0.x86_64
imgbased-0.6-0.1.el7ev.noarch

How reproducible:
100%
Whiteboard: install
Not regression bug

Steps to Reproduce:
1. Machine has been installed rhevh-ng using lvm before.
2. Automatic install machine with kickstart file in attachment
    key parameter:
    logvol /data --vgname=testgroup --size=10000 --name=data --noformat

3. Check with #fdisk -l

Actual results:
The original logical partitions are not cleared after installation

Expected results:
Automatic installation is successful, and partition is right.


Additional info:
When using "--useexisting" instead of "--noformat", the issue also occur

Comment 1 Wei Wang 2016-04-28 09:51:07 UTC
Created attachment 1151790 [details]
kickstart file

Comment 2 Fabian Deutsch 2016-04-28 09:55:51 UTC
First: What did you try to test?

For reference the complete storage part from the ks from comment 1:

clearpart --list=/dev/sda1,/dev/mapper/testgroup-swap,/dev/mapper/testgroup-root
^^ It only takes device partitions, not LVs - Also, just devnames, not paths (sdb1 vs /dev/sdb1)

part pv.01 --size=10000 --ondisk=/dev/sda
part pv.02 --size=15000 --ondisk=/dev/sda
part /boot --fstype=xfs --size=4300 --ondisk=/dev/sda
volgroup testgroup2 pv.01 pv.02

logvol / --vgname=testgroup2 --size=6000 --name=root --fstype=ext3
logvol swap --vgname=testgroup2 --size=2000 --name=swap
logvol /data --vgname=testgroup --size=10000 --name=data --noformat

--noformat only means that this disk will not be formated (no fs will be created).

Comment 3 Wei Wang 2016-04-29 03:57:12 UTC
hi Fabian,

From official document https://github.com/rhinstaller/pykickstart/blob/master/docs/kickstart-docs.rst#logvol we can see the '--noformat' parameter is belong to logvol command. 

   logvol

   Create a logical volume for Logical Volume Management (LVM).

   logvol <mntpoint> --vgname=<name> --size=<size> --name=<name> <options>

   --noformat

       Use an existing logical volume and do not format it.

   --useexisting

       Use an existing logical volume and reformat it.

and form Comment 2 I know that we cannot clear the original lvs any more, so is it a little awkward about '--noformat', or the explanation of this parameter in the document is not correct?

Comment 4 Fabian Deutsch 2016-04-29 08:00:02 UTC
Oh - I think it's my fault, my statement in comment 2 is probably wrong.

But then my question: What is the bug here?

IIUIC with the kcikstart you use, /data should not be reformated. Correct?
And what happens?

Comment 6 Sandro Bonazzola 2016-05-02 09:47:24 UTC
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.