| Summary: | [DOCS] No mention of proxy settings for Maven | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Jaspreet Kaur <jkaur> |
| Component: | Documentation | Assignee: | brice <bfallonf> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Tomas Schlosser <tschloss> |
| Severity: | high | Docs Contact: | Vikram Goyal <vigoyal> |
| Priority: | medium | ||
| Version: | 3.1.0 | CC: | aos-bugs, bmeng, haowang, jokerman, mmccomas, tschloss |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-11 03:23:53 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Jaspreet Kaur
2016-04-29 07:34:10 UTC
I've created a PR for this: https://github.com/openshift/openshift-docs/pull/2491 Meng Bo, as this is a new procedure to the docs, can I ask for a QA test please? I hope there's enough information to test this out and hopefully pass. If you need more information please let me know. Thanks! Hi, Tomas, could you please help verify this ? Hello, I would recommend other possibilities then what is documented: 1) provide $HTTP_PROXY_HOST and $HTTP_PROXY_PORT environment variables in .s2i/environment or in the BuildConfig - this will generate the settings.xml for the user - optionally, you can use other environment variables $HTTP_PROXY_USERNAME $HTTP_PROXY_PASSWORD $HTTP_PROXY_NONPROXYHOSTS - works for all xPaaS images except FIS 2) put your custom-made settings.xml into <git>/configuration/settings.xml - works for all xPaaS images (including FIS) 3) put your settings Other points: - don't use MAVEN_ARGS env var, use MAVEN_ARGS_APPEND instead (so you don't have to add everything, just the specifics) - using custom assemble script (as suggested in linked solution) is completely wrong approach Tomas Thanks very much for the extra information. I've updated the PR: https://github.com/openshift/openshift-docs/pull/2491 I think step 3 you mention above might need more info, though. Did the comment get cuttoff? I'm also eager to hear any other feedback you have, or if you have any more information. Thanks! Sorry, I must have hit the send button too soon. The third option would be to put your settings.xml anywhere in the git and use MAVEN_ARGS_APPEND variable to point to it (e.g. MAVEN_ARGS_APPEND=/tmp/source/<path_within_git>). Pull request looks good. I'd add other optional environment variables to it for completeness: - HTTP_PROXY_PASSWORD - HTTP_PROXY_NONPROXYHOSTS Tomas, Thanks so much for the extra info. I've updated the PR: https://github.com/openshift/openshift-docs/pull/2491 Can I ask for an ack that everything is correct? One thing, you mention that what was missing was "the third option". Does that mean that what you've given me are three different options, instead of three steps to a procedure, like I have written up? That's all. Thanks again. Yes, these are three separate options, not steps to follow. Value of append should contain also -s switch i.e. MAVEN_ARGS_APPEND="-s path/to/file" Tomas, Sure. I've fixed the topic: https://github.com/openshift/openshift-docs/pull/2491 Is there anything else you'd like to mention? If not, I can probably go ahead with this. Thanks, again. Looks good to me! Thanks for doing the update! Thanks, Tomas! I'll put this onto peer review. Commit pushed to master at https://github.com/openshift/openshift-docs https://github.com/openshift/openshift-docs/commit/5c3943969fd3d6d3ab143580410f2135df6afd96 Merge pull request #2491 from bfallonf/bz1331656 Bug 1331656 added maven proxy section |