Bug 1331788

Summary:	[RFE-Reweight-by-utilization]:- Reweight-by-utilization command should accept parameterized arguments instead of positional parameters
Product:	Red Hat Ceph Storage	Reporter:	shylesh <shmohan>
Component:	RADOS	Assignee:	Sage Weil <sweil>
Status:	CLOSED DEFERRED	QA Contact:	ceph-qe-bugs <ceph-qe-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	1.3.2	CC:	anharris, ceph-eng-bugs, dzafman, hnallurv, jdurgin, kchai, nlevine
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	3.*
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-01-30 14:59:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description shylesh 2016-04-29 13:53:05 UTC

Description of problem:
As of now "ceph osd reweight-by-utilization" accepts positional parameter, in which argument order should be [oload,max_change, max_osd, --no-increasing].

If user has to specify max_osd then he has to specify max_change otherwise based on position command will assume it as max_change. ex: "ceph osd reweight-by-utilization 200 10"  will consider 10 as max_change while user might think it as max_osd. so if its like "ceph osd reweight-by-utilization --olad <val> --max_change <val> --max_osd <val> " would be better.

Version-Release number of selected component (if applicable):
1.3.2 Async

Comment 3 Sage Weil 2016-04-29 20:28:37 UTC

This is an artifact of the way the CLI works--it is always positional.  The mon protocol is structured in JSON, so the CLI could have a named argument mode, but currently that's not how it works.

Comment 6 Drew Harris 2019-01-30 14:59:59 UTC

I have closed this issue because it has been inactive for some time now. If you feel this still deserves attention feel free to reopen it.