Bug 1331798

Can reproduce the same problem with Satellite 6.2.9. 

# cat /usr/share/foreman/config/hooks/host/managed/after_create/10_fix_environment.sh 

#!/bin/sh

ACTION="$1"
FQDN="$2"

logger "foreman hook: executed $ACTION for $FQDN"

HOOK_OBJECT_FILE=$(mktemp -t foreman_hooks.XXXXXXXXXX)
cat > $HOOK_OBJECT_FILE

logger -t foreman-hook: $HOOK_OBJECT_FILE

ENV="` sed -e 's/^.*"environment_name":"\([^"]*\)".*/\1/g' <$HOOK_OBJECT_FILE`"
SOLLENV="` sed -e 's/^.*"hostgroup_title":"\([^"]*\)".*/\1/g' <$HOOK_OBJECT_FILE | awk -F/ '{ print $2}'`"
HOSTID="`sed -e 's/^.*"host":{[^{}]*"id":\([0-9]*\),.*$/\1/g' <$HOOK_OBJECT_FILE`"

logger -t foreman-hook: env $ENV sollenv $SOLLENV

if [ ! -z "$ENV" ]
then
    if [ "$ENV" != "$SOLLENV" ]
    then
       logger -t foreman-hook: "setting environment for $FQDN from $ENV to $SOLLENV"
       echo "hammer -u XXXXX -p XXXXX host update --id $HOSTID --environment $SOLLENV" 2>&1 | logger -t foreman-hook:
       hammer -u XXXXX -p XXXXX host update --id $HOSTID --environment $SOLLENV 2>&1 | logger -t foreman-hook:
    else
       logger "foreman-hook: $FQDN has correct Environment $ENV"
    fi
else
    which jgrep| logger -t foreman-hook:
fi


And the output is:
=================

May 19 13:32:07 satellite logger: foreman hook: executed after_create for host.example.com
May 19 13:32:07 satellite foreman-hook:: /tmp/foreman_hooks.RkPnann3v9
May 19 13:32:07 satellite foreman-hook:: env KT_Library_20160801_sles11_85 sollenv Library
May 19 13:32:07 satellite foreman-hook:: setting environment for host.example.com from KT_Library_20160801_sles11_85 to Library
May 19 13:32:09 satellite foreman-hook:: hammer -u XXXXX-p XXXXXhost update --id 2805 --environment Library
May 19 13:32:10 satellite foreman-hook:: Could not update the host:
May 19 13:32:10 satellite foreman-hook::  Resource host not found by id '2805'

Hello, unfortunately you cannot use hammer command with hosts which are currently being processed by the hook itself. The database transaction is not yet complete. Foreman hooks executes the script in separate context, so it is not possible to directly modify the ActiveRecord objects yet. RFE is filed as https://github.com/theforeman/foreman_hooks/issues/4

You can experience random behaviour according to which worker process gets the request. Anyway, please avoid this completely. I suggest a workaround, create a separate script that will be spawned on the background and add sleep command there, or create a service or process that will do the required tasks and communicate the data via UNIX sockets.

Also an alternative is to create Foreman plugin in Ruby that can do anything you want during any transaction:

http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin

Take foreman_hooks as an example but implement the required code as separate plugin. Then you can modify the host object as needed:

https://github.com/theforeman/foreman_hooks

@lzap, thanks for your input.