Bug 1331938

Summary:	glusterfsd: return actual exit status on mount process
Product:	[Community] GlusterFS	Reporter:	Prasanna Kumar Kalever <prasanna.kalever>
Component:	core	Assignee:	Prasanna Kumar Kalever <prasanna.kalever>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.11	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1331042	Environment:
Last Closed:	2016-06-28 12:16:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1331042, 1335731
Bug Blocks:	1330975, 1336332

Description Prasanna Kumar Kalever 2016-04-30 09:14:49 UTC

+++ This bug was initially created as a clone of Bug #1331042 +++

Description of problem:
Currently, we always exit mount process with the pid as the exit number
which is return value of the waitpid(), it is not the exit value of the
child process

Version-Release number of selected component (if applicable):
mainline

Expected results:
exit with actual status/code

--- Additional comment from Vijay Bellur on 2016-04-27 10:10:06 EDT ---

REVIEW: http://review.gluster.org/14094 (glusterfsd: fix to return actual exit status on mount process) posted (#1) for review on master by Prasanna Kumar Kalever (pkalever)

--- Additional comment from Vijay Bellur on 2016-04-29 09:24:02 EDT ---

COMMIT: http://review.gluster.org/14094 committed in master by Jeff Darcy (jdarcy) 
------
commit 36d025ef6f178ce5d8c6f7fa09e1cf236976b5ea
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Wed Apr 27 19:29:09 2016 +0530

    glusterfsd: fix to return actual exit status on mount process
    
    Problem:
    Currently, we always exit mount process with the pid as the exit number
    which is return value of the waitpid(), it is not the exit value of the
    child process
    
    Solution:
    Extract the actual exit code/status in case if the child terminated normally,
    that is, by calling exit(3) or _exit(2), or by returning from main()
    
    Change-Id: Iefec6e27b5a5a98a22f016e49967978853662e37
    BUG: 1331042
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/14094
    Tested-by: Prasanna Kumar Kalever <pkalever>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Talur <rtalur>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 1 Vijay Bellur 2016-04-30 09:32:29 UTC

REVIEW: http://review.gluster.org/14129 (glusterfsd: fix to return actual exit status on mount process) posted (#1) for review on release-3.7 by Prasanna Kumar Kalever (pkalever)

Comment 2 Vijay Bellur 2016-05-02 11:30:14 UTC

COMMIT: http://review.gluster.org/14129 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit f58fb8821d1c5d96a8f1eb83930a33a4379196e2
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Sat Apr 30 14:59:26 2016 +0530

    glusterfsd: fix to return actual exit status on mount process
    
    Problem:
    Currently, we always exit mount process with the pid as the exit number
    which is return value of the waitpid(), it is not the exit value of the
    child process
    
    Solution:
    Extract the actual exit code/status in case if the child terminated normally,
    that is, by calling exit(3) or _exit(2), or by returning from main()
    
    Backport of:
    > Change-Id: Iefec6e27b5a5a98a22f016e49967978853662e37
    > BUG: 1331042
    > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    > Reviewed-on: http://review.gluster.org/14094
    > Tested-by: Prasanna Kumar Kalever <pkalever>
    > Smoke: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > Reviewed-by: Raghavendra Talur <rtalur>
    > Reviewed-by: Jeff Darcy <jdarcy>
    
    Change-Id: Ib9fd878461b0b409c9d55d526cf60d7276c31775
    BUG: 1331938
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/14129
    Tested-by: Prasanna Kumar Kalever <pkalever>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Kaushal 2016-06-28 12:16:09 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user