Bug 1332066

Summary: [openshift-docs] Documentation missed the steps to add the secret which is used for CA cert into BuildConfig
Product: OpenShift Container Platform Reporter: Kenjiro Nakayama <knakayam>
Component: DocumentationAssignee: Ashley Hardin <ahardin>
Status: CLOSED CURRENTRELEASE QA Contact: Vikram Goyal <vigoyal>
Severity: unspecified Docs Contact: Vikram Goyal <vigoyal>
Priority: unspecified    
Version: 3.1.0CC: aos-bugs, jokerman, knakayam, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-13 18:04:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Kenjiro Nakayama 2016-05-02 01:38:39 UTC
Document URL: 

https://docs.openshift.com/enterprise/3.1/dev_guide/builds.html#other-authentication

Section Number and Name:

- Builds -> Other

Describe the issue: 

Even though doc said "add it to the builder service account and then your BuildConfig", it is missing a step to add the secret into the bc.

Suggestions for improvement: 

the numbering of OTHER should be

  1. create secret with .gitconfig
  2. add to sa/builder
  3. add secret to bc

Additional information:

The numbering format in this section is also wrong. It numbered them all as "1." like:

1. Create desired type of secret:...
   ...
1. Add the secret

Comment 1 Ashley Hardin 2016-05-04 18:27:43 UTC
Work in progress:
https://github.com/openshift/openshift-docs/pull/2003

Comment 2 Ashley Hardin 2016-05-05 20:45:39 UTC
@Kenjiro Please review and let me know if this satisfies the request: 
https://github.com/openshift/openshift-docs/pull/2003

Comment 3 Kenjiro Nakayama 2016-05-09 01:14:52 UTC
I commented on the PR link.

Comment 4 openshift-github-bot 2016-05-10 13:07:54 UTC
Commits pushed to master at https://github.com/openshift/openshift-docs

https://github.com/openshift/openshift-docs/commit/328f9c0a5b4fbd21712161e2c63fcbc3a972a7b7
Bug 1332066, added in missing step and fixed format of nested lists

https://github.com/openshift/openshift-docs/commit/4568f3276c9df2432bdc4fb6fd1f0a1464a018f0
Merge pull request #2003 from ahardin-rh/cacert-secret

Bug 1332066, added in missing step and fixed format of nested lists