Bug 1332206

Only (non blocker) issue I see is that you have some macros in 
comments sections. Should use %% there or replace the % entirely. 

Otherwise I see no issues and this package is APPROVED.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (2 clause)", "Unknown or generated". 3 files have unknown
     license. Detailed output of licensecheck in /home/fedora/kevin/1332206
     -python-pysocks/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-pysocks , python3-pysocks
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-pysocks-1.5.6-1.fc24.noarch.rpm
          python3-pysocks-1.5.6-1.fc24.noarch.rpm
          python-pysocks-1.5.6-1.fc24.src.rpm
python2-pysocks.noarch: W: no-documentation
python2-pysocks.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/sockshandler.py 644 /usr/bin/env
python3-pysocks.noarch: W: no-documentation
python3-pysocks.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/sockshandler.py 644 /usr/bin/env
python-pysocks.src:102: W: macro-in-comment %check
python-pysocks.src:105: W: macro-in-comment %{__python2}
python-pysocks.src:107: W: macro-in-comment %{__python3}
python-pysocks.src:108: W: macro-in-comment %endif
python-pysocks.src:112: W: macro-in-comment %doc
python-pysocks.src:114: W: macro-in-comment %license
python-pysocks.src:122: W: macro-in-comment %doc
python-pysocks.src:124: W: macro-in-comment %license
3 packages and 0 specfiles checked; 2 errors, 10 warnings.




Rpmlint (installed packages)
----------------------------
python2-pysocks.noarch: W: no-documentation
python2-pysocks.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/sockshandler.py 644 /usr/bin/env
python3-pysocks.noarch: W: no-documentation
python3-pysocks.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/sockshandler.py 644 /usr/bin/env
2 packages and 0 specfiles checked; 2 errors, 2 warnings.



Requires
--------
python2-pysocks (rpmlib, GLIBC filtered):
    python(abi)

python3-pysocks (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python2-pysocks:
    python-pysocks
    python2-pysocks

python3-pysocks:
    python3-pysocks



Source checksums
----------------
https://pypi.python.org/packages/03/a5/957346ba692216cc00e8146fb1a5da0854f8320d7eb073b1cfcb7ad977b5/PySocks-1.5.6.tar.gz :
  CHECKSUM(SHA256) this package     : a62b35b13968ba3642a973d115ae6a11be886b5f5ae0841a3ecad4b4f1d7deb1
  CHECKSUM(SHA256) upstream package : a62b35b13968ba3642a973d115ae6a11be886b5f5ae0841a3ecad4b4f1d7deb1


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1332206
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Thanks Kevin!  I'll fix those macros after import.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pysocks

python-pysocks-1.5.6-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a5e7a7d75b

python-pysocks-1.5.6-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5fd6be4390

python-pysocks-1.5.6-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9b61b26d3

python-pysocks-1.5.6-2.fc22, python-requests-2.10.0-1.fc22, python-urllib3-1.15.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a5e7a7d75b

python-pysocks-1.5.6-2.fc23, python-requests-2.10.0-1.fc23, python-urllib3-1.15.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9b61b26d3

python-pysocks-1.5.6-2.fc24, python-requests-2.10.0-1.fc24, python-urllib3-1.15.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5fd6be4390

python-pysocks-1.5.6-2.fc23, python-requests-2.10.0-1.fc23, python-urllib3-1.15.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

python-pysocks-1.5.6-2.fc24, python-requests-2.10.0-1.fc24, python-urllib3-1.15.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

python-pysocks-1.5.6-2.fc22, python-requests-2.10.0-1.fc22, python-urllib3-1.15.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.