Bug 1332370

Summary:	DHT: Once remove brick start failed in between Remove brick commit should not be allowed
Product:	[Community] GlusterFS	Reporter:	Sakshi <sabansal>
Component:	distribute	Assignee:	Sakshi <sabansal>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.8.0	CC:	amukherj, bugs, mselvaga, rmekala, sabansal, sasundar, smohan, spalai, storage-qa-internal
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1278325	Environment:
Last Closed:	2016-06-16 14:04:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1258875, 1278325, 1333237
Bug Blocks:

Description Sakshi 2016-05-03 04:14:15 UTC

+++ This bug was initially created as a clone of Bug #1278325 +++

+++ This bug was initially created as a clone of Bug #1258875 +++

Document URL: 
=============
DHT: Once remove brick start failed in between Remove brick commit should not be allowed 

Steps:
========
1. Create a distributed volume with three bricks and mount it on client using FUSE
2. From the mount point create lots of directories and one direcotry with 30k files
3. Remove one of the brick form the volume and while re-blance is in progress delete all directories and files from the mount point and due to this remove-brick operation failed 
4.Though remove-brick operation failed remove-commint job is getting succeeded, 

Expected Result:
================
Remove-brick commit should be allowed only when the remove-brick operation job is passed

--- Additional comment from Sakshi on 2016-01-08 04:18:00 EST ---

Patch posted at http://review.gluster.org/#/c/12513/

--- Additional comment from Vijay Bellur on 2016-02-04 03:59:26 EST ---

REVIEW: http://review.gluster.org/12513 (glusterd: remove-brick commit should not be allowed when remove-brick start failed) posted (#2) for review on master by Sakshi Bansal

--- Additional comment from Vijay Bellur on 2016-02-24 05:13:21 EST ---

REVIEW: http://review.gluster.org/12513 (glusterd: remove-brick commit should not succeed when migration failed) posted (#3) for review on master by Sakshi Bansal

--- Additional comment from Mike McCune on 2016-03-28 19:31:34 EDT ---

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

--- Additional comment from Vijay Bellur on 2016-04-07 02:33:24 EDT ---

REVIEW: http://review.gluster.org/12513 (glusterd: remove-brick commit should not succeed when migration failed) posted (#4) for review on master by Sakshi Bansal

--- Additional comment from Vijay Bellur on 2016-05-02 23:53:22 EDT ---

COMMIT: http://review.gluster.org/12513 committed in master by Atin Mukherjee (amukherj) 
------
commit 614a048c59d9b22e090acc0f1bdcb8c1be67f97a
Author: Sakshi Bansal <sabansal>
Date:   Thu Nov 5 15:09:31 2015 +0530

    glusterd: remove-brick commit should not succeed when migration failed
    
    While remove a brick if the data migration was not successful,
    remove-brick commit should not succeed as this can lead to
    data loss.
    
    Change-Id: I1eac0ef775cc6910ece0e46ebb04051444d54393
    BUG: 1278325
    Signed-off-by: Sakshi Bansal <sabansal>
    Reviewed-on: http://review.gluster.org/12513
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: Atin Mukherjee <amukherj>

Comment 1 Vijay Bellur 2016-05-03 04:20:37 UTC

REVIEW: http://review.gluster.org/14172 (glusterd: remove-brick commit should not succeed when migration failed) posted (#1) for review on release-3.7 by Sakshi Bansal

Comment 2 Vijay Bellur 2016-05-03 13:13:57 UTC

REVIEW: http://review.gluster.org/14190 (glusterd: remove-brick commit should not succeed when migration failed) posted (#1) for review on release-3.8 by Sakshi Bansal

Comment 3 Vijay Bellur 2016-05-05 13:30:34 UTC

COMMIT: http://review.gluster.org/14190 committed in release-3.8 by Atin Mukherjee (amukherj) 
------
commit a6614f7fa917b2f3e518338c560edb4115b99b30
Author: Sakshi Bansal <sabansal>
Date:   Thu Nov 5 15:09:31 2015 +0530

    glusterd: remove-brick commit should not succeed when migration failed
    
    While remove a brick if the data migration was not successful,
    remove-brick commit should not succeed as this can lead to
    data loss.
    
    Backport of http://review.gluster.org/#/c/12513/
    
    > Change-Id: I1eac0ef775cc6910ece0e46ebb04051444d54393
    > BUG: 1278325
    > Signed-off-by: Sakshi Bansal <sabansal>
    > Reviewed-on: http://review.gluster.org/12513
    > Smoke: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > Reviewed-by: Atin Mukherjee <amukherj>
    > Tested-by: Atin Mukherjee <amukherj>
    
    Change-Id: I1eac0ef775cc6910ece0e46ebb04051444d54393
    BUG: 1332370
    Signed-off-by: Sakshi Bansal <sabansal>
    Reviewed-on: http://review.gluster.org/14190
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 4 Niels de Vos 2016-06-16 14:04:45 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user