Bug 1332460

Summary: [features/worm] - when disabled, worm xl should simply pass requested fops to its child xl
Product: [Community] GlusterFS Reporter: Krutika Dhananjay <kdhananj>
Component: unclassifiedAssignee: Krutika Dhananjay <kdhananj>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, ndevos
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.9.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1334836 (view as bug list) Environment:
Last Closed: 2017-03-27 18:10:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1334836    

Description Krutika Dhananjay 2016-05-03 09:09:20 UTC 
Description of problem:

Same as subject

I found this while testing another change, where the anon fd ctx in posix xl was already initialised by the time a write fop came in (and posix_writev() is where I was expecting the initialisation to have happened). Turns out the initialisation was being done in posix_fgetxattr() when the fop requested by shard was writev(). I traced the call and found that it is being wound by worm translator as part of writev() even though it was disabled on my setup (default configuration).
With server side translators, if they are disabled, they should simply pass fop requested by the parent down to their child(ren) without doing anything else.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Vijay Bellur 2016-05-03 09:21:12 UTC 
REVIEW: http://review.gluster.org/14182 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#1) for review on master by Krutika Dhananjay (kdhananj)
Comment 2 Vijay Bellur 2016-05-04 06:20:21 UTC 
REVIEW: http://review.gluster.org/14182 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#2) for review on master by Karthik U S (ksubrahm)
Comment 3 Vijay Bellur 2016-05-04 07:12:11 UTC 
REVIEW: http://review.gluster.org/14182 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#3) for review on master by Karthik U S (ksubrahm)
Comment 4 Vijay Bellur 2016-05-04 13:44:30 UTC 
REVIEW: http://review.gluster.org/14182 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#4) for review on master by Karthik U S (ksubrahm)
Comment 5 Vijay Bellur 2016-05-04 14:04:25 UTC 
REVIEW: http://review.gluster.org/14182 (features/worm: When disabled, worm xl must directly pass fops to its child xl) posted (#5) for review on master by Karthik U S (ksubrahm)
Comment 6 Vijay Bellur 2016-05-10 16:33:31 UTC 
COMMIT: http://review.gluster.org/14182 committed in master by Niels de Vos (ndevos) 
------
commit e3fd1c1b7d9357161fd0ffe05e2617db1b9ffcd7
Author: Krutika Dhananjay <kdhananj>
Date:   Tue May 3 14:29:45 2016 +0530

    features/worm: When disabled, worm xl must directly pass fops to its child xl
    
    Change-Id: I56ea46c2743636ef7af5c85469cb2e186eadf21f
    BUG: 1332460
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14182
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Joseph Fernandes
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
Comment 7 Shyamsundar 2017-03-27 18:10:35 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/