Bug 1332625

Summary: [RFE] Allow array setting merging
Product: Red Hat Satellite Reporter: Bryan Kearney <bkearney>
Component: HammerAssignee: Lukas Zapletal <lzap>
Status: CLOSED ERRATA QA Contact: Renzo Nuccitelli <rnuccite>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bbuckingham, ehelms, jcallaha, lzap, rnuccite, sthirugn, xdmoon
Target Milestone: UnspecifiedKeywords: FutureFeature, Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-hammer_cli-0.5.1.11-4 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-14 21:00:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1305085    

Description Bryan Kearney 2016-05-03 15:15:11 UTC
Only hash is currently merged across YAML files, this patch will add array support.

Comment 1 Bryan Kearney 2016-05-03 15:15:15 UTC
Created from redmine issue http://projects.theforeman.org/issues/14590

Comment 2 Bryan Kearney 2016-05-03 15:15:25 UTC
Upstream bug assigned to lzap

Comment 3 Bryan Kearney 2016-05-03 16:19:59 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/14590 has been closed

Comment 7 Lukas Zapletal 2016-09-05 13:57:10 UTC
This is a subtask of https://bugzilla.redhat.com/show_bug.cgi?id=1305085 and since you verified it, there is nothing to verify here. Just doublecheck that https://bugzilla.redhat.com/show_bug.cgi?id=1305085 works as expected and all configuration files gets modified correctly according to the list.

Comment 8 Renzo Nuccitelli 2016-09-05 16:16:00 UTC
I wrote a script to check up changes: https://gist.github.com/renzon/abfb6aaee1f7c249421f80a18c115055.

Using it I got:

[root@mgmt5 ~]# backup_log 
cp: cannot stat ‘/etc/sysconfig/virt-who’: No such file or directory


CHANGING LOG LEVEL

[root@mgmt5 ~]# hammer admin logging --level-debug --all


CHECKING DIFFS:


[root@mgmt5 ~]# diff_log 
################ diffs on postgresql.conf : #####################
341c341
< client_min_messages=debug2
---
> #client_min_messages = notice		# values in order of decreasing detail:
352c352
< log_min_messages=debug2
---
> #log_min_messages = warning		# values in order of decreasing detail:
366c366
< log_min_error_statement=debug2
---
> #log_min_error_statement = error	# values in order of decreasing detail:
################ diffs on settings.yaml : #####################
27c27
<   :level: debug
---
>   :level: info
################ diffs on settings.yml : #####################
61c61
< :log_level: DEBUG
---
> :log_level: ERROR
################ diffs on puppet.conf : #####################
80,81d79
< 
< log_level=debug
################ diffs on dhcpd.conf : #####################
28c28
< log-facility local6;
---
> log-facility local7;
################ diffs on named.conf : #####################

################ diffs on tftp : #####################
15c15
<         server_args=-vvvv -s /var/lib/tftpboot -m /etc/tftpd.map
---
>         server_args     = -v -s /var/lib/tftpboot -m /etc/tftpd.map
################ diffs on mongod.conf : #####################

################ diffs on qpidd.conf : #####################
30c30
< log-enable=info+
---
> log-enable=error+
################ diffs on candlepin.conf : #####################
44,45d43
< 
< log4j.logger.org.candlepin.servlet.filter=DEBUG
################ diffs on server.conf : #####################
65c65
< # log_level: DEBUG
---
> # log_level:        The desired logging level. Options are: CRITICAL, ERROR, WARNING, INFO, DEBUG,
75c75
< log_level: DEBUG
---
> log_level: INFO
################ diffs on virt-who : #####################
diff: /etc/sysconfig/virt-who: No such file or directory
diff: /tmp/backup/foreman/log/virt-who: No such file or directory


ROLLING BACK TO PRODUCTION

[root@mgmt5 ~]# hammer admin logging --level-production --all
[root@mgmt5 ~]# diff_log 
################ diffs on postgresql.conf : #####################
341c341
< client_min_messages=notice
---
> #client_min_messages = notice		# values in order of decreasing detail:
352c352
< log_min_messages=warning
---
> #log_min_messages = warning		# values in order of decreasing detail:
366c366
< log_min_error_statement=error
---
> #log_min_error_statement = error	# values in order of decreasing detail:
################ diffs on settings.yaml : #####################

################ diffs on settings.yml : #####################

################ diffs on puppet.conf : #####################
80,81d79
< 
< log_level=notice
################ diffs on dhcpd.conf : #####################
28c28
< log-facility local6;
---
> log-facility local7;
################ diffs on named.conf : #####################

################ diffs on tftp : #####################
15c15
<         server_args=-v -s /var/lib/tftpboot -m /etc/tftpd.map
---
>         server_args     = -v -s /var/lib/tftpboot -m /etc/tftpd.map
################ diffs on mongod.conf : #####################

################ diffs on qpidd.conf : #####################

################ diffs on candlepin.conf : #####################
44,45d43
< 
< log4j.logger.org.candlepin.servlet.filter=WARN
################ diffs on server.conf : #####################
65c65
< # log_level: INFO
---
> # log_level:        The desired logging level. Options are: CRITICAL, ERROR, WARNING, INFO, DEBUG,
################ diffs on virt-who : #####################
diff: /etc/sysconfig/virt-who: No such file or directory
diff: /tmp/backup/foreman/log/virt-who: No such file or directory


So this issue is ok on sat vertion 6.2.2

Comment 10 errata-xmlrpc 2016-09-14 21:00:22 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1885