Bug 1332702

Created redmine issue http://projects.theforeman.org/issues/17240 from this bug

Upstream bug assigned to oprazak

Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/17240 has been resolved.

ON_QA isn't an accurate status since this is blocked by the other bug mentioned here. Moving to ASSIGNED

Ths blocking bug is ON_QA, moving this to ON_QA as well.

moving as mentioned in comment 12

Build:Satellite 6.4.0 snap22

The corrupted file is not moved to a separate "corrupted" directory, Hence not detected by the proxy

Corrupting the report file
fallocate -l 2 -p -n arf/054ad748-d009-4213-b34c-c9c5c6d28822/1/1537532121/1c378cb68fb5255db5bf39f994c287135b350be2a0c371b0f6d3429834153677

Error on running smart-proxy-openscap-send command
smart-proxy-openscap-send 
/usr/share/gems/gems/openscap-0.4.7/lib/openscap/openscap.rb:34:in `raise!': Document is empty [oscap_source.c:301] (OpenSCAP::OpenSCAPError)
Entity: line 1: parser error : Document is empty
Unable to parse XML at: '/var/tmp/9609f49a-3d29-437f-8a96-271749c0b4d7-054ad748-d009-4213-b34c-c9c5c6d28822-1-1537532121-20180921-20142-1ybngeg' [oscap_source.c:303]
Could not create Result DataStream session: File is not Result DataStream. [ds_rds_session.c:54]
	from /usr/share/gems/gems/openscap-0.4.7/lib/openscap/ds/arf.rb:30:in `initialize'
	from /usr/share/gems/gems/smart_proxy_openscap-0.6.10/lib/smart_proxy_openscap/arf_json.rb:19:in `new'
	from /usr/share/gems/gems/smart_proxy_openscap-0.6.10/lib/smart_proxy_openscap/arf_json.rb:19:in `as_json'
	from /usr/bin/smart-proxy-arf-json:7:in `<main>'
Could not move file: No such file or directory - (/arf/054ad748-d009-4213-b34c-c9c5c6d28822/1/1537532121/1c378cb68fb5255db5bf39f994c287135b350be2a0c371b0f6d3429834153677, /var/lib/foreman-proxy/openscap/corrupted/arf/054ad748-d009-4213-b34c-c9c5c6d28822/1/1537532121/1c378cb68fb5255db5bf39f994c287135b350be2a0c371b0f6d3429834153677) See /usr/share/foreman-proxy/lib/../logs/openscap-send.log

Connecting redmine issue http://projects.theforeman.org/issues/24508 from this bug

Build: Satellite 6.4.0 snap25

I See the Proxy sent the corrupted report to corrupted Dir, but the UI error counter wasn't triggered.

The counter works on the capsule log that are present in UI. But the error log about the corupted report is not present on the UI. 

Moving it back it assigned as the UI counter is not updated with number of failed reports

Sanket, if you mean the same counter as I do, it can't reflect this report and never did. Failed reports are reports that were successfully uploaded and contain failed rules. It means the actuals openscap check reports, host is failing to comply with the policy.

This BZ was addressing a problem, where the report was not uploaded at all, becauss of Satellite error. We don't have any internal error counters in Satellite as far as I know.

If I misunderstood, could you please upload a screenshot of page you have in mind? Thanks

Created attachment 1490404 [details]
Spool error Reports counter

This is the field I was looking at.

Under capsules/<capsule-name>/Services tab

Created attachment 1637708 [details]
Capsule show page with spool error

Ok, this should work in snaps for 6.7, corrupted report is moved to corrupted dir on capsule and server is able to detect it. Could QE verify?

Verified

Verified with:
- Satellite 6.8.0 snap 13

Test steps:
1. Have few scap reports from different hosts available in spool directory.
2. Corrupt report file in /var/spool/foreman-proxy/openscap/arf/* with 'fallocate -l 2 -p reportfile'
3. execute the script smart-proxy-openscap-send

Observation:
- "2 spool errors detected, inspect the appropriate file directly on Capsule" message on Satellite UI. 
(Go to Infrastructure > Capsule > select OpenSCAP capsule > Service )

- Corrupted reports are moved to /var/lib/foreman-proxy/openscap/corrupted/arf/

# smart-proxy-openscap-send
Traceback (most recent call last):
	4: from /usr/bin/smart-proxy-arf-json:7:in `<main>'
	3: from /opt/theforeman/tfm/root/usr/share/gems/gems/smart_proxy_openscap-0.7.3/lib/smart_proxy_openscap/arf_json.rb:19:in `as_json'
	2: from /opt/theforeman/tfm/root/usr/share/gems/gems/smart_proxy_openscap-0.7.3/lib/smart_proxy_openscap/arf_json.rb:19:in `new'
	1: from /opt/theforeman/tfm/root/usr/share/gems/gems/openscap-0.4.9/lib/openscap/ds/arf.rb:21:in `initialize'
/opt/theforeman/tfm/root/usr/share/gems/gems/openscap-0.4.9/lib/openscap/openscap.rb:25:in `raise!': Document is empty [oscap_source.c:302] (OpenSCAP::OpenSCAPError)
Entity: line 1: parser error : Document is empty
Unable to parse XML at: '/var/tmp/9b02828c-6b76-46b2-b44e-bf6ffa1a6609-ae1cfd9c-e9a9-4708-9ab0-f0b5a587f997-9-1599141116-20200903-11661-unraf9' [oscap_source.c:304]
Could not create Result DataStream session: File is not Result DataStream. [ds_rds_session.c:54]

# ls /var/lib/foreman-proxy/openscap/corrupted/arf/
7664e4d7-9573-4d2f-95e1-ec44bb6799f2  ae1cfd9c-e9a9-4708-9ab0-f0b5a587f997

Created attachment 1713627 [details]
Verification_screenshot

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.8 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4366