Bug 1332715 (kf5-kdgantt2)

Summary: Review Request: kf5-kdgantt2 - KDE PIM library for rendering Gantt graphs
Product: [Fedora] Fedora Reporter: Daniel Vrátil <me>
Component: Package ReviewAssignee: Rex Dieter <rdieter>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, rdieter
Target Milestone: ---Flags: rdieter: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-25 19:20:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 656997, 1332255    

Description Daniel Vrátil 2016-05-03 21:49:48 UTC
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-kdgantt2.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-kdgantt2-16.04.0-1.fc23.src.rpm
Description: KDE PIM library for rendering Gantt graphs
Fedora Account System Username: dvratil

Comment 1 Rex Dieter 2016-05-25 15:09:27 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=14249107


naming: ok

sources: ok
c9056f677a6e061811c6f1f6b7b029d3  kdgantt2-16.04.0.tar.xz

license: ok

URL: Not valid
1.  Should fix URL to (something like):
URL:     https://quickgit.kde.org/?p=%{framework}.git

macros: ok

scriptlets: ok

2.  SHOULD fix Obsoletes/Conflicts to use real pkg names (without %{?_isa}),
Obsoletes:      kdepim-libs%{?_isa} < 16.04.0
Conflicts:      kdepim-libs%{?_isa} < 16.04.0


Otherwise, pretty simple and clean, follows conventions of other kf5/pim related packages.

APPROVED

Comment 2 Rex Dieter 2016-05-25 15:16:18 UTC
pkgdb request submitted

Comment 3 Gwyn Ciesla 2016-05-25 15:47:15 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-kdgantt2

Comment 4 Rex Dieter 2016-05-25 19:20:55 UTC
imported