Bug 1332720 (kdepim-addons)

Summary:	Review Request: kdepim-addons - Additional plugins for KDE PIM applications
Product:	[Fedora] Fedora	Reporter:	Daniel Vrátil <me>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-26 14:48:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1332254, 1332255, 1332256, 1332717, 1332721, 1339703, 1339737, 1339840
Bug Blocks:	656997

Description Daniel Vrátil 2016-05-03 21:54:55 UTC

Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kdepim-addons.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kdepim-addons-16.04.0-1.fc23.src.rpm
Description: Additional plugins for KDE PIM applications
Fedora Account System Username: dvratil

Comment 1 Rex Dieter 2016-05-25 15:26:44 UTC

hrm, tracking down these build deps:

error: Failed build dependencies:
        cmake(KF5Gravatar) is needed by kdepim-addons-16.04.0-1.fc24.x86_64
        cmake(KF5MailCommon) is needed by kdepim-addons-16.04.0-1.fc24.x86_64
        cmake(KF5MessageComposer) is needed by kdepim-addons-16.04.0-1.fc24.x86_64
        cmake(KF5MessageCore) is needed by kdepim-addons-16.04.0-1.fc24.x86_64
        cmake(KF5MessageList) is needed by kdepim-addons-16.04.0-1.fc24.x86_64
        cmake(KF5MessageViewer) is needed by kdepim-addons-16.04.0-1.fc24.x86_64

looks like we need (at least?) 2 more pkgs: libgravatar, messagelib

Comment 2 Rex Dieter 2016-05-26 01:36:16 UTC

builds/installs locally ok (with minor %%files adjustments, appears to be several small typos)

naming: ok

sources: ok
6a3ce0c4d1c08f0de1245c83795e207d  kdepim-addons-16.04.0.tar.xz

URL: Not valid
1.  Should fix URL to (something like):
URL:     https://quickgit.kde.org/?p=%{framework}.git

macros: ok

scriptlets: ok

2.  SHOULD fix Conflicts/Obsoletes to not use %{_isa} (but reference real packages):

Obsoletes:      kdepim-libs%{?_isa} < 16.04.0
Conflicts:      kdepim-libs%{?_isa} < 16.04.0


Otherwise, looks good, follows conventions of other kf5/pim related packages, APPROVED

Comment 3 Rex Dieter 2016-05-26 10:35:54 UTC

pkgdb request submitted

Comment 4 Gwyn Ciesla 2016-05-26 14:25:25 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kdepim-addons

Comment 5 Rex Dieter 2016-05-26 14:48:50 UTC

imported, thanks.