Bug 1333095
| Summary: | [NoMethodError] undefined method `metrics_collector_queue_name' | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | John Prause <jprause> |
| Component: | C&U Capacity and Utilization | Assignee: | Keenan Brock <kbrock> |
| Status: | CLOSED ERRATA | QA Contact: | Nandini Chandra <nachandr> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.5.0 | CC: | carnott, cpelland, jdeubel, jhardy, kbrock, mfeifer, obarenbo, ssainkar, thenness |
| Target Milestone: | GA | Keywords: | ZStream |
| Target Release: | 5.5.5 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | c&u:report | ||
| Fixed In Version: | 5.5.5.2 | Doc Type: | Bug Fix |
| Doc Text: |
Previously, some reports run on virtual machines did not generate any data, and reported an error with the metrics_collector_queue_name method. This problem occurred when a virtual machine was disconnected from the EMS but remained connected to a cluster, and metrics collection continued to be scheduled for that virtual machine. The capture_cloud_targets metric has been rewritten to fix this issue, so that metrics collection only occurs on virtual machines which are both powered on and attached to an EMS.
|
Story Points: | --- |
| Clone Of: | 1332579 | Environment: | |
| Last Closed: | 2016-07-26 15:33:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1332579 | ||
| Bug Blocks: | |||
| Attachments: | |||
Hello Colin, Does this fix things for you. This has been fixed upstream on master 5.5 MR for this issue: https://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme/merge_requests/944 jared - there is an included patch. did you try using that to fix the customer's issue? *** Bug 1333096 has been marked as a duplicate of this bug. *** New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=7a4f936d9fcee3d5809f9179eb09c2bc5195130f commit 7a4f936d9fcee3d5809f9179eb09c2bc5195130f Merge: 36e52a8 8dd4da6 Author: Oleg Barenboim <obarenbo> AuthorDate: Tue Jun 14 11:37:41 2016 -0400 Commit: Oleg Barenboim <obarenbo> CommitDate: Tue Jun 14 11:37:41 2016 -0400 Merge branch 'cap_u_queue_name' into '5.5.z' Cap&U: don't capture vms that have no ems This is custom code and NOT a backport https://bugzilla.redhat.com/show_bug.cgi?id=1333095 The error: [NoMethodError]: undefined method `metrics_collector_queue_name' for nil:NilClass Method:[rescue in deliver] This has been fixed on master across a number of PRs. It is too invasive to back port these changes to 5.5. So this is a temporary fix that will fix the problem but will not get the performance advantages of those on master. Master has these instead: [#8429], [#8363], (and probably others) [#8429]: http://github.com/ManageIQ/manageiq/issues/8429 [#8363]: http://github.com/ManageIQ/manageiq/issues/8363 See merge request !944 app/models/metric/targets.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Created attachment 1167956 [details]
patch b to fix missing ems with infra provider
Providing a second patch to apply on an environment that has already been patched with the previous patch
Created attachment 1167957 [details]
patch ab (cumulative) to fix metrics_collector_queue_name error (missing ems)
Also adding 1333095_ab.patch which contains the contents of both _a and _b.
This will allow you to apply this to new customers.
The _a is currently in 5.5.z, working on getting second patch into z stream for next week
Created attachment 1172019 [details]
Patch c to fix cap u for storages
There were issues with the past patch for storages.
This is the current proposal for c.
This is meant to apply on top of patches a,b (or ab)
There is another patch abc that is a cumulation of a,b,c
Created attachment 1172020 [details]
patch abc to fix metrics_collector_queue_name error
Cumulative patch for metrics_collector_queue_name errors
I have a customer who has encountered the same reported problem but unlike the other SF cases I have reviewed (where the CFME level is at 5.5.2.4) this customer is at CFME 5.5.3.4. Is this patch appropriate for this level of code? Please advise New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=0ea81dd9b0dc24e2157bb0ce9778e7520373f104 commit 0ea81dd9b0dc24e2157bb0ce9778e7520373f104 Author: Keenan Brock <kbrock> AuthorDate: Tue Jun 14 15:41:03 2016 -0400 Commit: Keenan Brock <kbrock> CommitDate: Fri Jun 24 15:49:50 2016 -0400 Fix metrics_collector_queue_name error aka: Don't cap&u infra vms without an ems https://bugzilla.redhat.com/show_bug.cgi?id=1333095 The previous patches were for cloud ``` ERROR -- : [NoMethodError]: undefined method `metrics_collector_queue_name` for nil:NilClass app/models/metric/ci_mixin/capture.rb:19:in `queue_name_for_metrics_collection' app/models/metric/ci_mixin/capture.rb:69:in `perf_capture_queue' app/models/metric/capture.rb:127:in `block in perf_capture_timer' app/models/metric/capture.rb:112:in `each' app/models/metric/capture.rb:112:in `perf_capture_timer' ``` app/models/metric/ci_mixin/capture.rb | 5 +---- app/models/metric/targets.rb | 5 +++-- app/models/storage.rb | 4 ++++ 3 files changed, 8 insertions(+), 6 deletions(-) New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f8489706f3d4ee1157d75ef87100afae248dbcf8 commit f8489706f3d4ee1157d75ef87100afae248dbcf8 Merge: 177848f 0ea81dd Author: Greg Blomquist <gblomqui> AuthorDate: Sat Jun 25 00:55:20 2016 -0400 Commit: Greg Blomquist <gblomqui> CommitDate: Sat Jun 25 00:55:20 2016 -0400 Merge branch '55z_queue_name_infra' into '5.5.z' Fix metrics_collector_queue_name error aka: Don't cap & u infra vms that have no ems https://bugzilla.redhat.com/show_bug.cgi?id=1333095 The previous patches were for cloud This is not from a MR. This is not an issue on 5.6. The changes to 5.6 seemed a little too big for me, so I applied a simple fix to 5.5 --- Current error ``` ERROR -- : [NoMethodError]: undefined method `metrics_collector_queue_name` for nil:NilClass app/models/metric/ci_mixin/capture.rb:19:in `queue_name_for_metrics_collection' app/models/metric/ci_mixin/capture.rb:69:in `perf_capture_queue' app/models/metric/capture.rb:127:in `block in perf_capture_timer' app/models/metric/capture.rb:112:in `each' app/models/metric/capture.rb:112:in `perf_capture_timer' ``` See merge request !970 app/models/metric/ci_mixin/capture.rb | 5 +---- app/models/metric/targets.rb | 5 +++-- app/models/storage.rb | 4 ++++ 3 files changed, 8 insertions(+), 6 deletions(-) Verified in 5.5.5.2 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-1488.html |
Created attachment 1158902 [details] Only Send vms with an ems This will limit out the suspect VMs