Bug 1333118

Summary:	Adding labels and envs is tricky
Product:	OpenShift Container Platform	Reporter:	Dan McPherson <dmcphers>
Component:	Management Console	Assignee:	bpeterse
Status:	CLOSED ERRATA	QA Contact:	Yadan Pei <yapei>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.2.0	CC:	adellape, aos-bugs, jforrest, jokerman, mmccomas
Target Milestone:	---
Target Release:	3.2.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	When adding environment variable or label name-value pairs in the web console via "Add to Project", it was previously unclear whether it required clicking the "Add" button to actually the commit the changes before hitting "Create" at the bottom of the page. This bug fix updates the web console to disable the "Create" button while uncommitted name-value pairs are entered. A "Please add or clear this name-value pair" message is also displayed until the pair has been added or cleared.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-27 15:06:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan McPherson 2016-05-04 16:58:59 UTC

Description of problem:

1) It isn't obvious you have to press add to get an env or label to apply
2) The UI gives you a visual clue that not clicking add works (and it doesn't)


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Go to Add to Project and select a template
2. Fill in envs and labels and add some and leave key/values not added

Actual results:

If you press add before submitting, the key/values are added
Values that are left in the fields and not added aren't added
But when you submit the form, the values left in the fields go through the add sequence to go along side the values that were added.  So it looks like they were added.

Expected results:
Make clear before I go on to the next section whether I have done enough to actually add something.  Or making clicking add for the last one not necessary.



Additional Info:
It just isn't clear that clicking Add is necessary or not.  Does it mean add another one.  Or add this one.  It looks like add another one.

Comment 1 openshift-github-bot 2016-05-18 14:47:08 UTC

Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/08466e85e14340f2fbf403787ae492de7d0566c4
Bug 1333118 - Make for CLI tools a standalone help page

Comment 2 bpeterse 2016-05-27 14:12:09 UTC

PR https://github.com/openshift/origin-web-console/pull/18#issuecomment-221950664

merged to openshift-web-console, working on backport PR to openshift/ose

Comment 3 Jessica Forrester 2016-06-03 12:40:24 UTC

backport merged to ose/master

Comment 5 Yadan Pei 2016-06-06 07:29:34 UTC

Tested against openshift v3.2.1.1-1-g33fa4ea with IE11, Edge25, Safari9, Firefox46, Chrome 49
openshift v3.2.1.1-1-g33fa4ea
kubernetes v1.2.0-36-g4a3f9c5
etcd 2.2.5

Now when key/value uncommitted changes exists, "Create" button is disabled and warning message "Please add or clear this name-value pair" will printed

Which I think works well

Comment 7 errata-xmlrpc 2016-06-27 15:06:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1343