Bug 1333741
| Summary: | Review Request: php-nikic-fast-route - Fast implementation of a regular expression based router | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Johan Cwiklinski <fedora> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-05-12 01:29:19 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Johan Cwiklinski
2016-05-06 09:30:09 UTC
Created attachment 1154539 [details]
phpci.log
phpCompatInfo version 5.0.0 DB version 1.8.1 built May 03 2016 07:41:55 CEST static analyze results
Created attachment 1154541 [details]
review.txt
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1333741
Buildroot used: fedora-rawhide-x86_64
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13945108 [!]: Package is named according to the Package Naming Guidelines. [!]: Final provides and requires are sane (see attachments). From composer.json "name": "nikic/fast-route", so %global pk_project fast-route Not blockers, just FYI (old EL-5 stuff) [x]: Buildroot is not present [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Package has no %clean section with rm -rf %{buildroot} (or Thanks for your comments :) I've fixed package name. I do no plan this package for EL-5. Spec URL: http://odysseus.x-tnd.be/fedora/php-nikic-fast-route/php-nikic-fast-route.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-nikic-fast-route/php-nikic-fast-route-1.0.0-2.fc23.src.rpm -%global pk_project fastroute
+%global pk_project fast-route
-Release: 1%{?dist}
+Release: 2%{?dist}
+* Fri May 06 2016 Johan Cwiklinski <johan AT x-tnd DOT be> - 1.0.0-2
+- Fix package name
[x]: Package is named according to the Package Naming Guidelines.
[x]: Final provides and requires are sane (see attachments).
No blocker.
=== APPROVED ===
Thank you very much for the review :) Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-nikic-fast-route php-nikic-fast-route-1.0.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-36dae62660 php-nikic-fast-route-1.0.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4effa5019d php-nikic-fast-route-1.0.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6d9d6bdcf php-nikic-fast-route-1.0.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-36dae62660 php-nikic-fast-route-1.0.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4effa5019d php-nikic-fast-route-1.0.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6d9d6bdcf php-nikic-fast-route-1.0.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. php-nikic-fast-route-1.0.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. php-nikic-fast-route-1.0.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |