Bug 1333803

Summary:	Detach tier fire before the background fixlayout is complete may result in failure
Product:	[Community] GlusterFS	Reporter:	Joseph Elwin Fernandes <josferna>
Component:	tiering	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8.0	CC:	bugs, dlambrig, kramdoss, sankarshan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1332136
Clones:	1333804 (view as bug list)		Environment:
Last Closed:	2016-06-16 14:05:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1332136, 1333934
Bug Blocks:	1332957, 1333804

Description Joseph Elwin Fernandes 2016-05-06 12:54:14 UTC

+++ This bug was initially created as a clone of Bug #1332136 +++

Description of problem:


Detach tier fire before the background fixlayout is complete may result in failure, as the removal of the xattr may fail.

Fix is During detach check if background fixlayout is done, if not done ignore
the case and continue detach.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-05-02 07:00:46 EDT ---

REVIEW: http://review.gluster.org/14147 (tier/detach : During detach check if background fixlayout is done) posted (#2) for review on master by Joseph Fernandes

--- Additional comment from Vijay Bellur on 2016-05-02 07:42:58 EDT ---

REVIEW: http://review.gluster.org/14147 (tier/detach : During detach check if background fixlayout is done) posted (#3) for review on master by Joseph Fernandes

--- Additional comment from Vijay Bellur on 2016-05-04 10:07:44 EDT ---

REVIEW: http://review.gluster.org/14147 (tier/detach : During detach check if background fixlayout is done) posted (#4) for review on master by Joseph Fernandes

--- Additional comment from Vijay Bellur on 2016-05-06 08:46:58 EDT ---

COMMIT: http://review.gluster.org/14147 committed in master by Dan Lambright (dlambrig) 
------
commit abd27041ebcb3c6ee897ad253fc248e3bb1823e6
Author: Joseph Fernandes <josferna>
Date:   Mon May 2 16:20:30 2016 +0530

    tier/detach : During detach check if background fixlayout is done
    
    During detach check if background fixlayout is done, if not done ignore
    the case and continue detach.
    
    Change-Id: I5d5cfc0e73d0eb217fdeab54c432dc4af8bc598d
    BUG: 1332136
    Signed-off-by: Joseph Fernandes <josferna>
    Reviewed-on: http://review.gluster.org/14147
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: N Balachandran <nbalacha>
    Reviewed-by: Dan Lambright <dlambrig>

Comment 1 Vijay Bellur 2016-05-06 12:58:19 UTC

REVIEW: http://review.gluster.org/14241 (tier/detach : During detach check if background fixlayout is done) posted (#1) for review on release-3.8 by Joseph Fernandes

Comment 2 Vijay Bellur 2016-05-06 20:11:41 UTC

COMMIT: http://review.gluster.org/14241 committed in release-3.8 by Dan Lambright (dlambrig) 
------
commit 9aec39440229d48256938b67e738302400d52f08
Author: Joseph Fernandes <josferna>
Date:   Mon May 2 16:20:30 2016 +0530

    tier/detach : During detach check if background fixlayout is done
    
    During detach check if background fixlayout is done, if not done ignore
    the case and continue detach.
    
    Backport of http://review.gluster.org/14147
    
    > Change-Id: I5d5cfc0e73d0eb217fdeab54c432dc4af8bc598d
    > BUG: 1332136
    > Signed-off-by: Joseph Fernandes <josferna>
    > Reviewed-on: http://review.gluster.org/14147
    > Smoke: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > Reviewed-by: N Balachandran <nbalacha>
    > Reviewed-by: Dan Lambright <dlambrig>
    > Signed-off-by: Joseph Fernandes <josferna>
    
    Change-Id: I16f0320a2c07ac1d137bd4f27697722049df803c
    BUG: 1333803
    Signed-off-by: Joseph Fernandes <josferna>
    Reviewed-on: http://review.gluster.org/14241
    Smoke: Gluster Build System <jenkins.com>
    Tested-by: Joseph Fernandes
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 3 Niels de Vos 2016-06-16 14:05:31 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user