Bug 1333816

Summary: python-django-threadedcomments: Provide a Python 3 subpackage
Product: [Fedora] Fedora Reporter: Tomas Orsava <torsava>
Component: python-django-threadedcommentsAssignee: Luis Bazan <bazanluis20>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: bazanluis20, dkrejci, jberan, lbalhar, mhroncok
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-django-threadedcomments-1.0.1-1.fc26 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-20 12:44:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1285816, 1333770    
Attachments:
Description Flags
Update to patched 1.0.1 version including Python 3 subpackage
none
Python 3 compatibility patch
none
Update to patched 1.0.1 version including Python 3 subpackage
none
Update to patched 1.0.1 version including Python 3 subpackage none

Description Tomas Orsava 2016-05-06 13:22:33 UTC 
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's OK to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 24 as well.


If you need more instructions, a guide for porting Python-based RPMs is
available at [2].
If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
[2] http://python-rpm-porting.readthedocs.io/
Comment 1 Dominika Krejčí 2016-06-28 10:31:32 UTC 
Hi Luis, do you need any help with adding Python 3 support?
Comment 2 Jan Kurik 2016-07-26 04:06:06 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.
Comment 3 Jan Beran 2016-08-08 10:53:11 UTC 
There is a Python 3 compatibility issue: https://github.com/HonzaKral/django-threadedcomments/issues/79
Comment 4 Jan Beran 2016-09-01 07:18:42 UTC 
Created attachment 1196602 [details]
Update to patched 1.0.1 version including Python 3 subpackage

I prepared a spec file update that includes
- update to version 1.0.1
- url and source update
- modernized specfile with Python 3 packaging
Comment 5 Jan Beran 2016-09-01 07:20:35 UTC 
Created attachment 1196605 [details]
Python 3 compatibility patch

Thanks to Dominika Krejci for the patch!
Comment 6 Jan Beran 2016-09-08 12:38:45 UTC 
Created attachment 1199060 [details]
Update to patched 1.0.1 version including Python 3 subpackage

Adjusted spec file
Comment 7 Jan Beran 2016-09-08 14:18:33 UTC 
Created attachment 1199123 [details]
Update to patched 1.0.1 version including Python 3 subpackage

Fix of sum/summary
Comment 8 Lumír Balhar 2016-09-09 07:03:27 UTC 
Hello.

This patch looks good to me, thanks. If maintainer has nothing against, we can push this change after a week.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15553000

Have a nice day.
Comment 9 Red Hat Bugzilla 2023-09-14 03:22:12 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days