Bug 1333928
| Summary: | Review Request: python-searchlightclient - OpenStack Indexing and Search API Client Library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alfredo Moralejo <amoralej> |
| Component: | Package Review | Assignee: | Andy Mender <andymenderunix> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | andymenderunix, karlthered, mhroncok, package-review, ppisar, vincent, ykarel |
| Target Milestone: | --- | Flags: | andymenderunix:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-08-26 08:37:10 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 177841 | ||
| Bug Blocks: | |||
|
Description
Alfredo Moralejo
2016-05-06 17:02:01 UTC
This is my first package, so I'm adding FE-NEEDSPONSOR blocker. Spec URL: https://raw.githubusercontent.com/amoralej/python-searchlightclient/master/python-searchlightclient.spec SRPM URL: https://github.com/amoralej/python-searchlightclient/blob/master/python-searchlightclient-0.2.1-1.fc25.src.rpm (fix links w/ fedora-review usage) Spec URL: https://raw.githubusercontent.com/amoralej/python-searchlightclient/master/python-searchlightclient.spec SRPM URL: https://github.com/amoralej/python-searchlightclient/raw/master/python-searchlightclient-0.2.1-1.fc25.src.rpm Missing epoch to keystoneclient, otherwise, it's good. Hello, I'm not a reviewer but I have some comments on your review request.
First of all, there is a line too long in description.
$ rpmlint python-searchlightclient-0.2.1-1.fc25.src.rpm
python-searchlightclient.src: E: description-line-too-long C This is a client library for Searchlight built on the Searchlight API. It provides a Python API (the searchlightclient module) and a osc plugin for openstackclient CLI.
Then, I think you should use macros like that:
%global client python-searchlightclient
^^
Should be %global client searchlightclient and
%global sclient searchlightclient
^^
delete this line which is useless then
Name: %{client}
^^
should be python-%{client}
For more details and if you want do others review requests of python software, you should see https://fedoraproject.org/wiki/Packaging:Python
You could also use macro for summary to avoid repetitions.
Summary: OpenStack Indexing and Search API Client Library
^^
Moreover, sources seems to be different from upstream.
$ sha256sum -b python-searchlightclient-0.2.1.tar.gz rpmbuild/SOURCES/python-searchlightclient-0.2.1.tar.gz
16494d6d9441b43ea77e65dee7c6423631198cadc24068c59f5947a6a37d2e70 *python-searchlightclient-0.2.1.tar.gz
97a39ed792d3535740a91c71d9b22b198a07fdaf5ccb32043b8a09f8a21c1fd7 *rpmbuild/SOURCES/python-searchlightclient-0.2.1.tar.gz
Why do you add these dependancies ?
BuildRequires: python-setuptools
BuildRequires: git
BuildRequires: python-hacking >= 0.10.2
BuildRequires: python-coverage >= 3.6
I'm really sorry, I meant I'd rather do macros like this
%global client python-searchlightclient
^^
%global client searchlightclient and
%global sclient searchlightclient
^^
delete this line
Name: %{client}
^^
python-%{client}
because I think it would make the spec easier to understand, so what do you think ?
Moved to Queens. Removed RDO-QUEENS tracker bug as queens released long ago, if needed it can be proposed for RDO Next release i.e victoria. Alfredo and Haikel, what is the current situation of this request? Neither the latest SPEC files nor the SRPMs can be downloaded anymore. No more interest in this package. Closing it as wontfix. |