Bug 1334112

Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/immanetize/pintail/pintail.git/plain/pintail.spec?id=ec3733276d954ed9bf62d270c6501c2813e14b8c
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/immanetize/pintail/fedora-rawhide-x86_64/00266844-pintail/pintail-0.2-1.fc25.src.rpm

Now shipping a newer upstream tag, with added requires.

- Spec file as given by url is not the same as in SRPM. Please update the Spec you provide in Spec URL.

- License text not included. You must include it by using the %license macro.
  See: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

- Upstream changed license from LGPLv2+ to GPLv2+, but they did not update the copyright statement in the beginning of every source code file. Please report this. Also, the COPYING file included in the tarball is LGPLv2, which does not reflect the change in https://github.com/projectmallard/pintail/commit/a15500c3fd936f58bc88f5a8aa47dd365d8414b2

- rpmlint complains:
pintail.noarch: E: explicit-lib-dependency python3-urllib3 -- this is an automatic dependency, no need to add it in the Spec
pintail.noarch: W: summary-not-capitalized -- please use Build web sites...
pintail.noarch: E: description-line-too-long -- no more than 79 characters per line

- Changelog format is not consistent for all entries.

(In reply to Eduardo Mayorga from comment #2)

> - Upstream changed license from LGPLv2+ to GPLv2+, but they did not update
> the copyright statement in the beginning of every source code file. Please
> report this. Also, the COPYING file included in the tarball is LGPLv2, which
> does not reflect the change in
> https://github.com/projectmallard/pintail/commit/
> a15500c3fd936f58bc88f5a8aa47dd365d8414b2
> 
Reported it here https://github.com/projectmallard/pintail/issues/17

%py3_build and %py3_install should work since it is a noarch package.

The shebang of:

https://github.com/projectmallard/pintail/blob/master/bin/pintail

Should be:

#!/usr/bin/python3 and not #!/usr/bin/env python3

%description looks like to be a single long line and no split in <80 characters lines.

The file:

https://github.com/projectmallard/pintail/blob/master/pintail/sample.cfg

Should be in %docs.

An by the way

%files
%doc
%{python3_sitelib}/*
%{_bindir}/%{name}

%doc is empy I you must use the %license macro for the COPYING file.

Please use a black line before %changelog

From build log in corp:

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.Ay244b
+ umask 022
+ cd /builddir/build/BUILD
+ cd pintail-1e00238e3446b199d043742b56d092e7b65aca72
+ /usr/bin/python3 setup.py test
running test
running egg_info
writing top-level names to pintail.egg-info/top_level.txt
writing pintail.egg-info/PKG-INFO
writing namespace_packages to pintail.egg-info/namespace_packages.txt
writing dependency_links to pintail.egg-info/dependency_links.txt
reading manifest file 'pintail.egg-info/SOURCES.txt'
writing manifest file 'pintail.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s

There are not test in sources so you should remove:


%check
%{__python3} setup.py test

Any update? If there is no response you, Pete, within one week, I'll close this bug as per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews.

I can take care of the packaging of these project, I have experience with python packages and I am in the docs team alredy.

I do not care what the stalled package guidelines say. We need this package for the docs project to move open, so I am reopening this ticket.

(In reply to Zach Oglesby from comment #8)
> I do not care what the stalled package guidelines say. We need this package
> for the docs project to move open, so I am reopening this ticket.

I can take care of this packaging, will update spec and source rpm in this same bug is it fine for you, any way the last spec is not ready yet I can update it.

I am in the docs team any way, can add more comantainers once it is aproved.

Please respect packaging guidelines I have opened a new review-request please review it and will add all comantainers needed from de docsteam.

I have anunce it in the docs mailing list:

https://lists.fedoraproject.org/archives/list/docs@lists.fedoraproject.org/thread/YPV46QRTNLFKDS4BPXZFELEVMGJEOKPT/

*** This bug has been marked as a duplicate of bug 1364194 ***

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days