Bug 1334639

Summary: imagePolicyConfig option is not set correctly
Product: OpenShift Container Platform Reporter: Gaoyun Pei <gpei>
Component: InstallerAssignee: Devan Goodwin <dgoodwin>
Status: CLOSED ERRATA QA Contact: Ma xiaoqiang <xiama>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.2.0CC: aos-bugs, dgoodwin, jokerman, mmccomas, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-07 10:56:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gaoyun Pei 2016-05-10 08:28:31 UTC
Description of problem:
Set openshift_master_image_policy_config={"maxImagesBulkImportedPerRepository": 3, "disableScheduledImport": true}
in ansible inventory by following https://github.com/openshift/openshift-ansible/blob/master/inventory/byo/hosts.ose.example#L63

During installation, master service failed to get started.
TASK: [openshift_master | Start and enable master] **************************** 
failed: [openshift-x.com] => {"failed": true}
msg: Job for atomic-openshift-master.service failed because the control process exited with error code. See "systemctl status atomic-openshift-master.service" and "journalctl -xe" for details.

Check the configuration of master-config.yaml:
imagePolicyConfig:
  '{"maxImagesBulkImportedPerRepository": 3, "disableScheduledImport": true}'


Version-Release number of selected component (if applicable):
openshift-ansible-3.0.88-1.git.0.31c3daf.el7.noarch.rpm

How reproducible:
Always

Steps to Reproduce:
1.As in Description
2.
3.

Actual results:
The imagePolicyConfig is not configured correctly

Expected results:
Should be configured like
imagePolicyConfig:
  disableScheduledImport: true
  maxImagesBulkImportedPerRepository: 3


Additional info:
It works when using "True" instead of "true" 
openshift_master_image_policy_config={"maxImagesBulkImportedPerRepository": 3, "disableScheduledImport": True}

Comment 1 Devan Goodwin 2016-05-12 15:46:20 UTC
The bug that will not die... this was fixed most recently in 3d667872314b2d91f64c5ce2bf282a91e6974a9d. However the last two builds .88 and .89 were hotfix builds with only explicit changes, so this did not make it in. 

This fix should be included in the next build, likely .90.

Comment 2 Devan Goodwin 2016-05-13 17:36:56 UTC
PR was: https://github.com/openshift/openshift-ansible/pull/1818

Comment 4 Gaoyun Pei 2016-05-25 02:58:29 UTC
Verify this bug with openshift-ansible-3.0.93-1.git.0.437c450.el7.noarch.rpm

Set the following option in ansible inventory:
openshift_master_image_policy_config={"maxImagesBulkImportedPerRepository": 3, "disableScheduledImport": true}

After installation, check /etc/origin/master/master-config.yaml:
imagePolicyConfig:
  disableScheduledImport: true
  maxImagesBulkImportedPerRepository: 3

Comment 6 errata-xmlrpc 2016-06-07 10:56:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1208