Bug 1334714

Summary: [RFE] Remove not needed boot entries from GRUB
Product: [oVirt] ovirt-node Reporter: Huijuan Zhao <huzhao>
Component: RFEsAssignee: Ryan Barry <rbarry>
Status: CLOSED DUPLICATE QA Contact: Huijuan Zhao <huzhao>
Severity: high Docs Contact:
Priority: high    
Version: 4.0CC: bugs, cshao, fdeutsch, fkong, huiwa, leiwang, mgoldboi, weiwang, yaniwang, ycui
Target Milestone: ovirt-4.0.1Keywords: FutureFeature
Target Release: ---Flags: rule-engine: ovirt-4.0.0+
ycui: testing_plan_complete?
mgoldboi: planning_ack+
fdeutsch: devel_ack+
ycui: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-15 13:44:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1140646    
Attachments:
Description Flags
screenshot of entry layout name
none
log
none
Boot entry screenshot
none
Boot entry in rhev-hypervisor7-ng-4.0-20160608.0 none

Description Huijuan Zhao 2016-05-10 12:07:55 UTC
Created attachment 1155688 [details]
screenshot of entry layout name

Description of problem:
The layout name is "rhel_$machine-name/ovirt-node-ng-**" on entry of RHEV-H grub, should delete "rhel", and $machine-name is not suitable, date is more suitable. And the name is too long.

Version-Release number of selected component (if applicable):
rhev-hypervisor7-ng-20160506.0.el7
imgbased-0.6-0.1.el7ev.noarch

How reproducible:
100%
Whiteboard:

Steps to Reproduce:
1. Anaconda install rhev-hypervisor7-ng-3.6-20160506.0.el7
2. Reboot and focus on entry of RHEV-H grub

Actual results:
1. After step2, the layout name shows "rhel_$machine-name/ovirt-node-ng-**"

Expected results:
2. After step2, the layout name should delete "rhel", and $machine-name is not suitable, date is more suitable. And the name is too long.

Additional info:
kickstart file:
# cat ngn.ks

liveimg --url=http://10.66.10.22:8090/rhevh/rhevh7-ng-36/rhev-hypervisor7-ng-3.6-20160506.0/rhev-hypervisor7-ng-3.6-20160506.0.x86_64.liveimg.squashfs

clearpart --all

autopart --type=thinp

rootpw --plaintext redhat

timezone --utc Asia/Harbin

zerombr

text

reboot

%post --erroronfail
imgbase layout --init
imgbase --experimental volume --create /var 4G
%end

Comment 1 Huijuan Zhao 2016-05-10 12:09:06 UTC
Created attachment 1155689 [details]
log

Comment 2 Fabian Deutsch 2016-05-17 11:51:31 UTC
Fixed in imgbased:

    osupdater: Use metadata for boot entry
    
    Previously the boot entry title was based o nthe os- and system-release
    files.
    But to have an alignment with the image, and because it's now available,
    this patch switches to use the image metadata for building the boot entry title.
    
    Change-Id: I6c361b6fbeca94ca8563e7601b7c93c1998c346a
    Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1334713
    Signed-off-by: Fabian Deutsch <fabiand>

Comment 3 Huijuan Zhao 2016-06-02 03:41:10 UTC
Tested in downstream build RHEVH-7.2-20160520.t.0-RHEVH-x86_64-dvd1.iso, 
1. The layout of boot entry is still too long and some words display incomplete(Please refer to the attachment "boot entry screenshot")
2. There is still "Red Hat Enterprise Linux (....)" on the boot entry, can replace this to RHEV-H related words?


Test version:
RHEVH-7.2-20160520.t.0-RHEVH-x86_64-dvd1.iso
redhat-release-rhev-hypervisor-3.6-0.27.el7.x86_64
imgbased-0.6-0.1.el7ev.noarch
kernel-3.10.0-327.18.2.el7.x86_64

Test steps:
1. Install RHEVH-7.2-20160520.t.0-RHEVH-x86_64-dvd1.iso via CDROM
2. Reboot and focus on entry of RHEV-H grub

Test results:
1. After step2, 
   (a) The layout of boot entry is still too long and some words display incomplete (Please refer to the attachment "boot entry screenshot")
   (b) There is still "Red Hat Enterprise Linux (....)" on the boot entry, can replace this to RHEV-H related words?

Comment 4 Huijuan Zhao 2016-06-02 03:42:04 UTC
Created attachment 1163874 [details]
Boot entry screenshot

Comment 5 Huijuan Zhao 2016-06-13 08:45:22 UTC
Still encounter this bug in rhev-hypervisor7-ng-4.0-20160608.0, it shows as below(detailed info please refer to attachment):
-------------------------------------------------------------
Red Hat Enterprise Linux (3.10.0-327.18.2.el7.x86_64) 7.2
tboot 1.8.1
-------------------------------------------------------------

So this bug is not fixed in rhev-hypervisor7-ng-4.0-20160608.0, I will change the status to ASSIGNED.

Comment 6 Red Hat Bugzilla Rules Engine 2016-06-13 08:45:27 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 7 Huijuan Zhao 2016-06-13 08:50:31 UTC
Created attachment 1167275 [details]
Boot entry in rhev-hypervisor7-ng-4.0-20160608.0

Comment 8 Fabian Deutsch 2016-06-13 09:12:28 UTC
This will only be fixed once we have the Node specific anaconda builds.

Comment 9 Fabian Deutsch 2016-06-15 13:44:52 UTC
I'm closing this bug, because of the comments it's a dupe of bug 1334713.

A new bug will be opened to track the spurious boot entries.

*** This bug has been marked as a duplicate of bug 1334713 ***

Comment 10 Fabian Deutsch 2016-06-15 13:47:52 UTC
The new bug is bug 1346872