Bug 1334874

Summary:	Image can be updated to itself
Product:	[oVirt] ovirt-node	Reporter:	Fabian Deutsch <fdeutsch>
Component:	Installation & Update	Assignee:	Fabian Deutsch <fdeutsch>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Huijuan Zhao <huzhao>
Severity:	medium	Docs Contact:
Priority:	high
Version:	4.0	CC:	bugs, cshao, huzhao, ycui
Target Milestone:	ovirt-4.0.0-rc	Flags:	rule-engine: ovirt-4.0.0+ huzhao: testing_plan_complete+ rule-engine: planning_ack+ fdeutsch: devel_ack+ ycui: testing_ack+
Target Release:	4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-node-ng-installer-ovirt-3.6-2016051700.iso	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-01 12:23:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Node	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1340378, 1340382
Bug Blocks:	1140646

Description Fabian Deutsch 2016-05-10 17:20:08 UTC

Description of problem:
Currently an image can be updated to itself:

1. Install
2. Reboot
3. yum updated -> runs update
4. Reboot
5- yum update -> would update again

The problem is that the placeholder package (which is used to determin if a update is needed or not) is not updated often enough.
I.e. the placeholder will always be 1 inside of an image, but the image update will always increase i.e. 1.$builddate.

Thus an update will aways be suggested.

Version-Release number of selected component (if applicable):
master/4.0/3.6

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Fabian Deutsch 2016-05-17 11:54:40 UTC

*** Bug 1330841 has been marked as a duplicate of this bug. ***

Comment 2 Huijuan Zhao 2016-05-23 07:32:21 UTC

Can reproduce this bug, this bug is duplicate with Bug 1330841.

Test version:
ovirt-node-ng-image-update-placeholder-007-1.el7.noarch
imgbased-0.6-0.201604150305git1e3b28f.el7.centos.noarch
ovirt-release36-007-1.noarch
ovirt-release-host-node-007-1.el7.noarch

The update version:
ovirt-node-ng-image-update-3.6.5-1.20160426.0.el7.noarch.rpm

How reproducible:
100%

Steps to Reproduce:
1. Anaconda install NGN 4.0.
2. Download ovirt-node-ng-image-update-3.6.5-1.20160426.0.el7.noarch.rpm
3. yum install ovirt-node-ng-image-update-3.6.5-1.20160426.0.el7.noarch.rpm
4. Check 2 packages:
   [root@dhcp-10-125 ~]# rpm -qa | grep ovirt-node
   ovirt-node-ng-image-update-placeholder-007-1.el7.noarch
   ovirt-node-ng-image-update-3.6.5-1.20160426.0.el7.noarch
   [root@dhcp-10-125 ~]# rpm -qa | grep imgbased
   imgbased-0.6-0.201604150305git1e3b28f.el7.centos.noarch
5. Reboot rhev-h
6. Check 2 packages
   [root@dhcp-10-125 ~]# rpm -qa | grep ovirt-node
   ovirt-node-ng-image-update-placeholder-3.6.5-0.0.master.20160425075818.gite23be77.el7.noarch
   [root@dhcp-10-125 ~]# rpm -qa | grep imgbased
   imgbased-0.6-0.201604241653git1e3b28f.el7.centos.noarch
7. yum install ovirt-node-ng-image-update-3.6.5-1.20160426.0.el7.noarch.rpm  

Actual results:
1. After step6, the package is "ovirt-node-ng-image-update-placeholder-3.6.5-0.0.master.20160425075818.gite23be77.el7.noarch".
2. After step7, it upgrades again.

Expected results:
1. After step6, the package should be "ovirt-node-ng-image-update-3.6.5-1.20160426.0.el7.noarch".
2. After step7, can not upgrade as now is the latest build. There should be warning message: "Error: Nothing to do"

Additional info:
1. After step7, reboot rhev-h again, the results is the same as "Expected results".

Comment 3 Huijuan Zhao 2016-06-02 02:30:32 UTC

As Bug 1340378 and Bug 1340382, I can not test this issue via jenkins.
And for downstream builds, do not support upgrade now.
So I will verify this bug after Bug 1340378 is verified or downstream build can support upgrade.

Comment 4 Huijuan Zhao 2016-07-07 03:30:40 UTC

Test version:
1. Before upgrade:
ovirt-node-ng-installer-ovirt-4.0-2016062004.iso
imgbased-0.7.0-0.201606081307gitfb92e93.el7.centos.noarch
ovirt-node-ng-image-update-placeholder-4.0.0-1.el7.noarch
kernel-3.10.0-327.18.2.el7.x86_64
2. After upgrade:
imgbased-0.7.0-0.201606081307gitfb92e93.el7.centos.noarch
ovirt-node-ng-image-4.0.0-5.201606240219.el7.noarch
ovirt-node-ng-image-update-4.0.0-5.201606240219.el7.noarch
kernel-3.10.0-327.22.2.el7.x86_64

Test steps:
1. Install ovirt-node-ng-installer-ovirt-4.0-2016062004.iso
2. Reboot and login host, enable repos(bug 1352100).
3. Upgrade to the latest build:
   # yum update
4. Reboot and login new build, upgrade again:
   # yum update

Test results:
After step4, can not upgrade to itself:
[root@hp-dl385g8-03 ~]# yum update
Loaded plugins: fastestmirror, imgbased-warning
Warning: yum operations are not persisted across upgrades!
base                                                                                                                                           | 3.6 kB  00:00:00     
base-debuginfo                                                                                                                                 | 2.5 kB  00:00:00     
centos-ovirt40-candidate                                                                                                                       | 3.4 kB  00:00:00     
centosplus                                                                                                                                     | 3.4 kB  00:00:00     
extras                                                                                                                                         | 3.4 kB  00:00:00     
group_cockpit-cockpit-preview                                                                                                                  | 3.9 kB  00:00:00     
ovirt-4.0                                                                                                                                      | 2.9 kB  00:00:00     
ovirt-4.0-centos-gluster37                                                                                                                     | 2.9 kB  00:00:00     
ovirt-4.0-epel/x86_64/metalink                                                                                                                 | 4.2 kB  00:00:00     
ovirt-4.0-epel                                                                                                                                 | 4.3 kB  00:00:00     
ovirt-4.0-patternfly1-noarch-epel                                                                                                              | 3.0 kB  00:00:00     
ovirt-4.0-pre                                                                                                                                  | 2.9 kB  00:00:00     
updates                                                                                                                                        | 3.4 kB  00:00:00     
virtio-win-stable                                                                                                                              | 3.0 kB  00:00:00     
(1/2): ovirt-4.0-epel/x86_64/updateinfo                                                                                                        | 576 kB  00:00:01     
(2/2): ovirt-4.0-epel/x86_64/primary_db                                                                                                        | 4.2 MB  00:00:10     
Loading mirror speeds from cached hostfile
 * base: mirrors.tuna.tsinghua.edu.cn
 * centosplus: mirrors.btte.net
 * extras: mirrors.btte.net
 * ovirt-4.0: resources.ovirt.org
 * ovirt-4.0-epel: mirrors.neusoft.edu.cn
 * updates: mirrors.tuna.tsinghua.edu.cn
No packages marked for update

So this bug is fixed on ovirt-node-ng-image-4.0.0-5.201606240219.el7.noarch, I will change the status to VERIFIED.