Bug 1334884

Can you please uncomment "level=TRACE" in /etc/NetworkManager/NetworkManager.conf, run "systemctl restart NetworkManager" and when the issue happens, attach the output of "journalctl -u NetworkManager -b"? Thanks!

A quick fix for this should be:

 $ nmcli connection mod em1 ipv6.may-fail yes

(or uncheck "require ipv6 addressing to complete" in nm-applet).

The reason is that since commit 7d1709d7f649 ("device: check may_fail
when progressing to IP_CHECK"), NM will not progress the activation if
IPv6 doesn't reach IP_DONE (unless may-fail=yes). But when the
ipv6.method is set to 'ignore' the IPv6 status goes to IP_FAIL
instead of IP_DONE, and thus IPv6 is never considered completed.

I think this is wrong, I'll prepare a patch.

Created attachment 1174983 [details]
[PATCH] libnm-core: ip-config: normalize may-fail for disabled IP methods

(In reply to Beniamino Galvani from comment #4)
> Created attachment 1174983 [details]
> [PATCH] libnm-core: ip-config: normalize may-fail for disabled IP methods

     _("property cannot be TRUE when method is set to ignore"));
                           ^^^^ FALSE


- return NM_SETTING_VERIFY_NORMALIZABLE_ERROR;
+ return NM_SETTING_VERIFY_NORMALIZABLE;

You can also make the verify() failures NORMALIZABLE. In this case, nm_connection_verify() still returns TRUE, but nm_connection_normalize() has something to fix.
For NM core, it doesn't matter because it always just right away normalizes the connection. For a client, the difference is, that an ill connection appears to be valid.
It seems to me, that as we previously allowed for such configurations, we should not start marking them invalid now. Thus, NM_SETTING_VERIFY_NORMALIZABLE is preferable.
Then, also add a comment:
  /* Failures from here on, are NORMALIZABLE... */




rest lgtm.

Created attachment 1176389 [details]
[PATCH v2] libnm-core: ip-config: normalize may-fail for disabled IP methods

(In reply to Thomas Haller from comment #5)
> 
>      _("property cannot be TRUE when method is set to ignore"));
>                            ^^^^ FALSE

Ok; changed to "should be TRUE" because NORMALIZABLE is returned now.
 
> You can also make the verify() failures NORMALIZABLE. In this case,
> nm_connection_verify() still returns TRUE, but nm_connection_normalize() has
> something to fix.
> For NM core, it doesn't matter because it always just right away normalizes
> the connection. For a client, the difference is, that an ill connection
> appears to be valid.
> It seems to me, that as we previously allowed for such configurations, we
> should not start marking them invalid now. 

Right, fixed in v2.

lgtm

(In reply to Beniamino Galvani from comment #6)
> Created attachment 1176389 [details]
> [PATCH v2] libnm-core: ip-config: normalize may-fail for disabled IP methods

If a NMSetting has multiple invalid conditions, then verify() *must* return the most severe error status.

nm-setting-ip6-config.c:verify() gets that wrong.

If a connection has
  ipv6.method="ignore"
  ipv6.may-fail=no
  ipv6.token=::0:1
then then entire setting is invalid (due to a non-normalized token). thus, the function should return NORMALIZABLE_ERROR. In v2, it wouldn't.

that's what the comment 
  /* Failures from here on are NORMALIZABLE... */
means.
But it must come after
  /* Failures from here on are NORMALIZABLE_ERROR... */

rest lgtm

(In reply to Thomas Haller from comment #8)
> If a NMSetting has multiple invalid conditions, then verify() *must* return
> the most severe error status.

Fixed and applied to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=ac73758305faf938318e6c888faf8bc954b8289d

nm-1-2:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?h=nm-1-2&id=b5b7260873563d5f1a5bced3f2c98d7d1df7f8b4

NetworkManager-1.2.4-1.fc24 network-manager-applet-1.2.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f739ece3cf

NetworkManager-1.2.4-1.fc24, network-manager-applet-1.2.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f739ece3cf

NetworkManager-1.2.4-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-fade485364

NetworkManager-1.2.4-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-fade485364

network-manager-applet-1.2.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f739ece3cf

NetworkManager-1.2.4-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.