Bug 1334938

Summary:	Service Dialogue Check box not changing to r/w
Product:	Red Hat CloudForms Management Engine	Reporter:	Josh Carter <jocarter>
Component:	Automate	Assignee:	eclarizi
Status:	CLOSED ERRATA	QA Contact:	Shveta <sshveta>
Severity:	high	Docs Contact:
Priority:	medium
Version:	5.5.0	CC:	cpelland, gmccullo, hkataria, jhardy, mfeifer, mkanoor, mpovolny, obarenbo, simaishi, tfitzger
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.6.0
Hardware:	All
OS:	All
Whiteboard:	service:dialog
Fixed In Version:	5.6.0.8	Doc Type:	Bug Fix
Doc Text:	Cause: read_only property is not recognized for all dynamic dialogs Consequence: Service Dialogue Check box not changing to r/w Fix: read_only property is recognized for all dynamic dialogs Result:	Story Points:	---
Clone Of:
Clones:	1335583 (view as bug list)		Environment:
Last Closed:	2016-06-29 16:01:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1335583

Description Josh Carter 2016-05-10 20:56:39 UTC

Description of problem:

I have a Service Dialog that has a Check Box element that is dynamic.

The automation method turns on or off the read_only attribute based on the value of another element.

Setting $evm.object['read_only'] to true works as expected and makes the element read only in the UI when ordering a service that uses the dialog. However, even though the automation code runs when the other element is updated and $evm.object['read_only'] is set to false the element stays read only in the UI.

Attached is the automation.log from ordering the service associated with the service dialog, the method from the automate model, and a screenshot of the UI. (I am setting the element value to true when setting read_only to false so that I have a visual confirmation that the code is running and getting to the code that sets $evm.object['read_only'] = false.)



Version-Release number of selected component (if applicable):5.5.3


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 5 CFME Bot 2016-05-18 15:50:56 UTC

https://github.com/ManageIQ/manageiq/pull/8784

Comment 6 Greg McCullough 2016-05-18 15:53:24 UTC

Resetting flags so this ticket is 5.6 only.  Bug 1335583 was already created for 5.5.z.

Comment 7 CFME Bot 2016-05-19 18:06:11 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/9b815a32e290a76b60996b171350a298e6ac4f60

commit 9b815a32e290a76b60996b171350a298e6ac4f60
Author:     Erik Clarizio <eclarizi>
AuthorDate: Wed May 18 08:19:07 2016 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Thu May 19 07:31:42 2016 -0700

    Ensure read_only property is recognized for all dynamic dialogs
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1334938

 app/assets/javascripts/dialog_field_refresh.js     | 16 +++++++++++
 app/models/dialog_field_check_box.rb               |  2 +-
 app/models/dialog_field_date_control.rb            |  2 +-
 app/models/dialog_field_date_time_control.rb       |  7 +++--
 app/models/dialog_field_drop_down_list.rb          |  2 +-
 app/models/dialog_field_radio_button.rb            |  2 +-
 app/models/dialog_field_text_box.rb                |  2 +-
 spec/javascripts/dialog_field_refresh_spec.js      | 32 ++++++++++++++++++++++
 spec/models/dialog_field_check_box_spec.rb         |  4 +--
 spec/models/dialog_field_date_control_spec.rb      |  4 +--
 spec/models/dialog_field_date_time_control_spec.rb |  9 +++---
 spec/models/dialog_field_drop_down_list_spec.rb    |  8 ++++--
 spec/models/dialog_field_radio_button_spec.rb      |  4 +--
 spec/models/dialog_field_text_box_spec.rb          |  4 +--
 14 files changed, 75 insertions(+), 23 deletions(-)

Comment 8 Oleg Barenboim 2016-05-20 16:04:04 UTC

PR https://github.com/ManageIQ/manageiq/pull/8784 has been merged and backported to Darga.

Comment 9 Shveta 2016-05-26 20:04:23 UTC

Using the method attached.
Changing the read-only values in method impacts the checkbox correctly.
verified in 5.6.0.8-rc1.20160524155303_f2a5a50

Comment 11 errata-xmlrpc 2016-06-29 16:01:19 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348