Bug 1335160

Summary:	Not all Lorax-generated content is tracked by metadata
Product:	[Fedora] Fedora	Reporter:	Jeremy Cline <jcline>
Component:	lorax	Assignee:	Brian Lane <bcl>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	anaconda-maint-list, bcl
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	lorax-25.6-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-15 23:44:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeremy Cline 2016-05-11 13:02:54 UTC

Description of problem:

I work on a project called Pulp. One thing Pulp tries to do is mirror yum repositories and installation trees via HTTP. For yum repositories this is fairly straightforward using repodata. However, we've noticed that there are several images and pieces of content that aren't in the treeinfo file.

It would be great if Lorax ensured every piece of content that makes it into installation trees is described by metadata (presumably in the treeinfo file).

Version-Release number of selected component (if applicable):

master

Examples
----------------

Here are a few examples I've noticed.

Fedora
^^^^^

Fedora 23's Server variant released repo has an ``EFI/`` and ``isolinux/`` directory. None of the files in either of those directories are present in the ``treeinfo`` metadata or any other metadata as far as I can tell, so Pulp isn't able to discover them short of guessing filenames.

Fedora 24's Server variant beta repo looks to be missing both the directories Fedora 23 does, but it's also missing the images/efiboot.img and images/macboot.img.

CentOS
^^^^^

In addition to the files missing in Fedora, CentOS also has GPG keys, the GPL, a EULA, and various other text files. I believe these all come from Pungi or some other tool particular to CentOS, so (unless I'm mistaken), there's nothing to be done in Lorax for this.

RHEL
^^^^

RHEL is similiar to CentOS, but it _also_ contains release notes. Again, I don't know that Lorax is responsible for these files.

Comment 1 Brian Lane 2016-05-11 17:34:40 UTC

Not all the content of the tree/iso is tracked by .treeinfo (eg. EFI and isolinux are for the boot.iso) but there are a few things that were missing from lorax's .treeinfo, take a look at this patch:

https://github.com/rhinstaller/lorax/pull/122

which adds the efiboot, macboot, product, and updates images (if they exist) to the file.

Comment 2 Jeremy Cline 2016-05-12 13:28:52 UTC

Thanks for the quick turn-around! That looks good to me.

Is there any metadata that does reference the files in the EFI and isolinux directories? Do we, when mirroring a tree, not need those directories?

Sorry for the basic questions, I'm still getting a handle on how everything comes together in a tree.

Comment 3 Brian Lane 2016-05-12 15:25:51 UTC

No, those directories are not needed when mirroring things. Everything needed for PXE booting, for example, is referenced by .treeinfo

The basic tree is created by lorax and is actually the content of the boot.iso. Dor the DVD's and the full package tree pungi extends that and adds additional information to .treeinfo like the checksums.

Comment 4 Jeremy Cline 2016-05-12 15:52:15 UTC

Okay, great to know. Thanks so much!