Bug 1335230

Summary: protocol/client: clang compile warnings in client-helpers.c
Product: [Community] GlusterFS Reporter: Kaleb KEITHLEY <kkeithle>
Component: protocolAssignee: Pranith Kumar K <pkarampu>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: atumball, bugs
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.12.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-08-27 03:52:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kaleb KEITHLEY 2016-05-11 15:38:47 UTC
Description of problem:

Making all in src
  CC       client.lo
  CC       client-helpers.lo
client-helpers.c:1163:30: warning: address of 'local->loc' will always evaluate to 'true' [-Wpointer-bool-conversion]
                if (!&local->loc) {
                    ~ ~~~~~~~^~~
client-helpers.c:1174:30: warning: address of 'local->loc' will always evaluate to 'true' [-Wpointer-bool-conversion]
                if (!&local->loc) {
                    ~ ~~~~~~~^~~
client-helpers.c:1197:30: warning: address of 'local->loc' will always evaluate to 'true' [-Wpointer-bool-conversion]
                if (!&local->loc) {
                    ~ ~~~~~~~^~~
client-helpers.c:1342:30: warning: address of 'local->loc' will always evaluate to 'true' [-Wpointer-bool-conversion]
                if (!&local->loc) {
                    ~ ~~~~~~~^~~
client-helpers.c:1360:30: warning: address of 'local->loc' will always evaluate to 'true' [-Wpointer-bool-conversion]
                if (!&local->loc) {
                    ~ ~~~~~~~^~~
client-helpers.c:1386:30: warning: address of 'local->loc' will always evaluate to 'true' [-Wpointer-bool-conversion]
                if (!&local->loc) {
                    ~ ~~~~~~~^~~
client-helpers.c:1417:30: warning: address of 'local->loc' will always evaluate to 'true' [-Wpointer-bool-conversion]
                if (!&local->loc) {
                    ~ ~~~~~~~^~~
7 warnings generated.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anuradha 2016-08-09 07:02:47 UTC
Sent as part of http://review.gluster.org/#/c/15010/