Bug 1335612

Description of problem:
Three bugs exist described below i)-iii).

i) Unable to generate Neutron L2 Agent manifest entries agent.
[reason] The following line in /usr/lib/python2.7/site-packages/packstack/modules/common.py does not accept interface without IP.
> ipaddr = info['ipaddress_{}'.format(interface)]
[howToSolve] check 'ipaddress_{}'.format(interface) exists in info before the line above

[symptom]

[root@qas ~]# packstack --answer-file=qas
Welcome to the Packstack setup utility

The installation log file is available at: /var/tmp/packstack/20310305-194440-RMimyM/openstack-setup.log

Installing:
Clean Up                                             [ DONE ]
Discovering ip protocol version                      [ DONE ]
Setting up ssh keys                                  [ DONE ]
...
Adding Neutron L3 manifest entries                   [ DONE ]
Adding Neutron L2 Agent manifest entries          [ ERROR ]

ERROR : 'ipaddress_enp2s0'
Please check log file /var/tmp/packstack/20310305-194440-RMimyM/openstack-setup.log for more information


---------------------------------------------------------------

ii) Unable to generate Neutron L2 Agent manifest entries agent.
[reason] the following segments in /usr/lib/python2.7/site-packages/packstack/plugins/neutron_350.py assume that all nodes have the same interface name for the same network (It DOES conflict with the idea of CONFIG_USE_SUBNETS.)
[howToSolve] add the line starting with '+'
    for host in network_hosts | compute_hosts:
        manifestfile = "%s_neutron.pp" % (host,)
        manifestdata = "$cfg_neutron_ovs_host = '%s'\n" % host
        if host in network_hosts:
            manifestdata += "$create_bridges = true\n"
        else:
            manifestdata += "$create_bridges = false\n"
        # neutron ovs port only on network hosts
+       tmp_iface_arr = iface_arr
        if (
            agent == "openvswitch" and (
                (host in network_hosts and tunnel_types)
                or 'vlan' in ovs_type)
        ):
            if config['CONFIG_USE_SUBNETS'] == 'y':
                iface_arr = [
                    common.cidr_to_ifname(i, host, config) for i in iface_arr
                ]
            config["CONFIG_NEUTRON_OVS_BRIDGE_IFACES"] = iface_arr
        manifestdata += getManifestTemplate(template_name)
        appendManifestFile(manifestfile, manifestdata + "\n")
        # Additional configurations required for compute hosts and
        # network hosts.
        manifestdata = getManifestTemplate('neutron_bridge_module')
        appendManifestFile(manifestfile, manifestdata + '\n')
+       iface_arr = tmp_iface_arr

[symptom]

[root@qas ~]# packstack --answer-file=qas
Welcome to the Packstack setup utility

The installation log file is available at: /var/tmp/packstack/20310305-195036-d9vO31/openstack-setup.log

Installing:
Clean Up                                             [ DONE ]
...
Adding Neutron L3 manifest entries                   [ DONE ]
Adding Neutron L2 Agent manifest entries          [ ERROR ]

ERROR : Cannot translate CIDR to interface, invalid parameters were given.
Please check log file /var/tmp/packstack/20310305-195036-d9vO31/openstack-setup.log for more information


---------------------------------------------------------------

iii) Unable to apply the neutron manifest file.
[reason] tiny bug in /usr/share/openstack-puppet/modules/packstack/lib/puppet/parser/functions/force_interface.rb which does not assume ifaddr would be null (so IPAddr.new ifaddr fails)
[howToSolve] add the following lines starting with '+'
              ifaddr = lookupvar("ipaddress_#{interface}")
+             ifcidr = nil
+             if !ifaddr.nil?
                ifcidr = IPAddr.new ifaddr
+             end

[symptom]

[root@qas ~]# packstack --answer-file=qas
Welcome to the Packstack setup utility

The installation log file is available at: /var/tmp/packstack/20160502-222422-qFIXpE/openstack-setup.log

Installing:
Clean Up                                             [ DONE ]
（中略）
Applying 192.168.1.1_neutron.pp
Applying 192.168.1.2_neutron.pp
192.168.1.2_neutron.pp:                           [ ERROR ]       
Applying Puppet manifests                         [ ERROR ]

ERROR : Error appeared during Puppet run: 192.168.1.2_neutron.pp
Error: address family must be specified at /var/tmp/packstack/e84b2e397d9e490183f10881e3443072/manifests/192.168.1.2_neutron.pp:67 on node myhost2
You will find full trace in log /var/tmp/packstack/20160502-222422-qFIXpE/manifests/192.168.1.2_neutron.pp.log
Please check log file /var/tmp/packstack/20160502-222422-qFIXpE/openstack-setup.log for more information

Version-Release number of selected component (if applicable):
Mitaka, default components.

How reproducible:
100% for each.

Steps to Reproduce:
I summarized details in the following article (but it is in Japanese).
http://qiita.com/PitneS/items/1b1de2725220cbd071d5

Actual results:
described above.

Expected results:
described above.

Additional info:
nothing.