Bug 1335818

Summary:	Revert "features/shard: Make o-direct writes work with sharding: http://review.gluster.org/#/c/13846/"
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	sharding	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1335821 1335822 (view as bug list)		Environment:
Last Closed:	2017-03-27 18:11:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1335821, 1335822

Description Krutika Dhananjay 2016-05-13 09:44:00 UTC

Description of problem:
Revert this patch for two reasons:

1) It introduces high fop latencies
2) Even with the patch, there is no true odirect behavior since the workaround in the patch doesn't reduce the caching done in kernel's page cache etc.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-05-13 09:54:26 UTC

REVIEW: http://review.gluster.org/14328 (Revert "features/shard: Make o-direct writes work with sharding") posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Vijay Bellur 2016-05-17 11:01:43 UTC

COMMIT: http://review.gluster.org/14328 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 7d67d7d7a6c86a2f42d619c8d21e5e1f44a19b5c
Author: Krutika Dhananjay <kdhananj>
Date:   Fri May 13 15:18:22 2016 +0530

    Revert "features/shard: Make o-direct writes work with sharding"
    
    This reverts commit c272c71391cea9db817f4e7e38cfc25a7cff8bd5.
    
    This is for two reasons:
    1) It introduces high fop latencies
    2) Even with the patch, there is no true odirect behavior since the
       workaround in the patch doesn't reduce the caching done in kernel's
       page cache as far as writes on anon fds associated with individual
       shards is concerned.
    
    Change-Id: Iaf411198b56237ca0601deaf17f69ef178d7e769
    BUG: 1335818
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14328
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 3 Shyamsundar 2017-03-27 18:11:09 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/