Bug 1335898

Summary: Enabling a repository needs to fail on pulp error
Product: Red Hat Satellite Reporter: John Mitsch <jomitsch>
Component: RepositoriesAssignee: John Mitsch <jomitsch>
Status: CLOSED ERRATA QA Contact: Peter Ondrejka <pondrejk>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bbuckingham, cwelton, smane, tomckay
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1578922 (view as bug list) Environment:
Last Closed: 2018-02-21 16:51:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1578922    
Attachments:
Description Flags
screenshot none

Description John Mitsch 2016-05-13 13:39:48 UTC
Description of problem:

A repository can be enabled even if there is an error in pulp.


Version-Release number of selected component (if applicable):


How reproducible:
%100


Steps to Reproduce:
1. Turn off a repo in pulp
2. Try to enable this repo

-or-

1. Don't install ostree
2. Try to enable an ostree repo

Actual results:

you should see a pulp error in /var/log/messages but the repo will be available in the Products page.

Expected results:

The repo is not able to be enabled and an appropriate message is returned to the user when enabling it errors in pulp.

Additional info:

This is related to how we handle the task in dynflow. We should be enabling the repo in pulp first before we add it to the the database.

Comment 2 Brad Buckingham 2016-07-24 16:21:36 UTC
Created redmine issue http://projects.theforeman.org/issues/15824 from this bug

Comment 3 Bryan Kearney 2016-08-02 14:15:31 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/15824 has been closed

Comment 6 Peter Ondrejka 2016-11-29 13:18:07 UTC
Created attachment 1225826 [details]
screenshot

Verified using the ostree method in Satellite 6.3 snap 6, if ostree does not exist the repository is not enabled and the task is stopped.

Comment 7 John Mitsch 2016-12-19 21:56:14 UTC
*** Bug 1316167 has been marked as a duplicate of this bug. ***

Comment 10 Satellite Program 2018-02-21 16:51:07 UTC
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.
> 
> For information on the advisory, and where to find the updated files, follow the link below.
> 
> If the solution does not work for you, open a new bug report.
> 
> https://access.redhat.com/errata/RHSA-2018:0336