Bug 1336137
| Summary: | PREFIX is not honoured during build and install | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Niels de Vos <ndevos> |
| Component: | build | Assignee: | Niels de Vos <ndevos> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.7.11 | CC: | bugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.7.13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1335717 | Environment: | |
| Last Closed: | 2016-07-20 13:55:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1335717 | ||
| Bug Blocks: | |||
|
Description
Niels de Vos
2016-05-14 16:43:37 UTC
REVIEW: http://review.gluster.org/14338 (build: place glupy under $prefix while installing) posted (#1) for review on release-3.7 by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/14339 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#1) for review on release-3.7 by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/14340 (configure: Prevent glupy installation outside $prefix) posted (#1) for review on release-3.7 by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/14339 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#2) for review on release-3.7 by Aravinda VK (avishwan) REVIEW: http://review.gluster.org/14338 (build: place glupy under $prefix while installing) posted (#2) for review on release-3.7 by Aravinda VK (avishwan) REVIEW: http://review.gluster.org/14340 (configure: Prevent glupy installation outside $prefix) posted (#2) for review on release-3.7 by Aravinda VK (avishwan) REVIEW: http://review.gluster.org/14339 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#3) for review on release-3.7 by Anoop C S (anoopcs) REVIEW: http://review.gluster.org/14340 (configure: Prevent glupy installation outside $prefix) posted (#3) for review on release-3.7 by Anoop C S (anoopcs) COMMIT: http://review.gluster.org/14338 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) ------ commit 94b743782200b2399f2d23d4b47356e602f62777 Author: Niels de Vos <ndevos> Date: Sat May 14 19:19:39 2016 +0200 build: place glupy under $prefix while installing Regression testing on FreeBSD fails due to this error: --- install-pyglupyPYTHON --- /usr/home/jenkins/root/workspace/freebsd-smoke/install-sh -c -d '/usr/local/lib/python2.7/site-packages/gluster/glupy' mkdir: /usr/local/lib/python2.7/site-packages/gluster: Permission denied mkdir: /usr/local/lib/python2.7/site-packages/gluster: Permission denied *** [install-pyglupyPYTHON] Error code 1 The installation prefix is set to "/build/install" and glupy should be placed there as well. The default to "/usr/local" is incorrect. Cherry picked from commit a34c406445fc0294de41a8e4706f106a83e136a0: > Change-Id: I166412a271576f2344aecec94c7835f0fe9b1cf3 > BUG: 1198849 > Signed-off-by: Niels de Vos <ndevos> > Reviewed-on: http://review.gluster.org/13208 > Smoke: Gluster Build System <jenkins.com> > NetBSD-regression: NetBSD Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.com> > Reviewed-by: Kaleb KEITHLEY <kkeithle> Change-Id: I166412a271576f2344aecec94c7835f0fe9b1cf3 BUG: 1336137 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/14338 Smoke: Gluster Build System <jenkins.org> Tested-by: Aravinda VK <avishwan> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle> REVIEW: http://review.gluster.org/14339 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#4) for review on release-3.7 by Anoop C S (anoopcs) REVIEW: http://review.gluster.org/14340 (configure: Prevent glupy installation outside $prefix) posted (#4) for review on release-3.7 by Anoop C S (anoopcs) COMMIT: http://review.gluster.org/14339 committed in release-3.7 by Vijay Bellur (vbellur) ------ commit f9a6eba4e0b31247116256545b3c12e1df88c0de Author: Niels de Vos <ndevos> Date: Sat May 14 19:23:09 2016 +0200 build: Filter -D_FORTIFY_SOURCE from CFLAGS We use python-config to get recommended CFLAGS. It provides -D_FORTIFY_SOURCE=2 by default that conflicts with our --enable-debug option or a developer provided no-optimization option. Hence, filter it out from default CFLAGS. Cherry picked from commit 5e65701f2660d1be101da81bffea7721d4f9ece0: > Change-Id: Id80196baeb55415b1ea334e7b17143e56dfbadb3 > BUG: 1283948 > Co-authored-by: Kaleb S KEITHLEY <kkeithle> > Signed-off-by: Raghavendra Talur <rtalur> > Reviewed-on: http://review.gluster.org/12707 > Smoke: Gluster Build System <jenkins.com> > CentOS-regression: Gluster Build System <jenkins.com> > NetBSD-regression: NetBSD Build System <jenkins.org> > Reviewed-by: Kaleb KEITHLEY <kkeithle> Change-Id: Id80196baeb55415b1ea334e7b17143e56dfbadb3 BUG: 1336137 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/14339 Smoke: Gluster Build System <jenkins.org> Tested-by: Anoop C S <anoopcs> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle> COMMIT: http://review.gluster.org/14340 committed in release-3.7 by Vijay Bellur (vbellur) ------ commit 4d62806d3031cea33bab1641e0c14a1a8cb11c46 Author: Niels de Vos <ndevos> Date: Sat May 14 19:23:20 2016 +0200 configure: Prevent glupy installation outside $prefix glupy was installed in the global path outside the prefix path, even if --prefix is passed. ./configure --prefix=/usr/local make install Expected: ${DESTDIR}${prefix}/lib64/python<VERSION>/site-packages/gluster Actual: ${DESTDIR}/usr/lib64/python<VERSION>/site-packages/gluster prefix was not honoured. With this patch, glupy will be installed inside the prefix path. Cherry picked from commit 85de0c83392d861ba47c97664ff73fd7f8705a3a: > BUG: 1335717 > Change-Id: I810dd8d2d6c403540d4b738f5ab54237c7358bf6 > Signed-off-by: Aravinda VK <avishwan> > Reviewed-on: http://review.gluster.org/14315 > Smoke: Gluster Build System <jenkins.com> > Reviewed-by: Niels de Vos <ndevos> > NetBSD-regression: NetBSD Build System <jenkins.org> > Reviewed-by: Jeff Darcy <jdarcy> > CentOS-regression: Gluster Build System <jenkins.com> BUG: 1336137 Change-Id: I810dd8d2d6c403540d4b738f5ab54237c7358bf6 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/14340 Smoke: Gluster Build System <jenkins.org> Tested-by: Anoop C S <anoopcs> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Vijay Bellur <vbellur> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.13, please open a new bug report. glusterfs-3.7.13 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-July/027604.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |