Bug 1336517
Summary: | Disable hv-vpindex, hv-runtime, hv-reset, hv-synic & hv-stimer enlightenment for Windows | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Amnon Ilan <ailan> |
Component: | qemu-kvm-rhev | Assignee: | Miroslav Rezanina <mrezanin> |
Status: | CLOSED ERRATA | QA Contact: | huiqingding <huding> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 7.3 | CC: | chayang, ehabkost, huding, jen, jinzhao, juzhang, pbonzini, virt-maint, xfu |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | qemu-kvm-rhev-2.6.0-8.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-11-07 21:09:20 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1624786 |
Description
Amnon Ilan
2016-05-16 17:13:42 UTC
Based on the "hv-reset" evaluation, we decided to disable this enlightenment as well. Please add it to the list. Because these statements exist in the code today: DEFINE_PROP_BOOL("hv-vpindex", X86CPU, hyperv_vpindex, false), DEFINE_PROP_BOOL("hv-runtime", X86CPU, hyperv_runtime, false), DEFINE_PROP_BOOL("hv-synic", X86CPU, hyperv_synic, false), DEFINE_PROP_BOOL("hv-stimer", X86CPU, hyperv_stimer, false), DEFINE_PROP_BOOL("hv-reset", X86CPU, hyperv_reset, false) ...the enlightenments are present but "disabled." They could be enabled if someone wanted to turn them on. But in an email thread discussing this topic, Paolo has called for them to be deleted. To me, that means deleting the enlightenment field from the X86CPU structure. So what is the actual development action for this BZ? Is leaving it present but disabled good enough? I would just add an #if 0 around the property definitions, so that they cannot be enabled through libvirt. (In reply to Paolo Bonzini from comment #6) > I would just add an #if 0 around the property definitions, so that they > cannot be enabled through libvirt. Ok...this can be done. Fix included in qemu-kvm-rhev-2.6.0-8.el7 Verify this bug using the following version: qemu-kvm-rhev-2.6.0-12.el7 Step1: Download qemu-kvm-rhev-2.6.0-12.el7.src.rpm from brewweb Step2: Check hv-vpindex, hv-runtime, hv-reset, hv-synic & hv-stimer is disabled. # rpm -ivh qemu-kvm-rhev-2.6.0-12.el7.src.rpm # cd /root/rpmbuild/SPECS/ # rpmbuild -bp qemu-kvm.spec # cd /root/rpmbuild/BUILD # cd qemu-2.6.0/ # cat vim target-i386/cpu.c Actual result: hv-vpindex, hv-runtime, hv-reset, hv-synic & hv-stimer is disabled as following: #if 0 /* Disabled for Red Hat Enterprise Linux */ DEFINE_PROP_BOOL("hv-reset", X86CPU, hyperv_reset, false), DEFINE_PROP_BOOL("hv-vpindex", X86CPU, hyperv_vpindex, false), DEFINE_PROP_BOOL("hv-runtime", X86CPU, hyperv_runtime, false), DEFINE_PROP_BOOL("hv-synic", X86CPU, hyperv_synic, false), DEFINE_PROP_BOOL("hv-stimer", X86CPU, hyperv_stimer, false), #endif Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-2673.html |