Bug 1336655
| Summary: | Parse the tar header on the configuration volume and download a minimal amount of data | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Roy Golan <rgolan> |
| Component: | BLL.HostedEngine | Assignee: | Andrej Krejcir <akrejcir> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Artyom <alukiano> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.1.1 | CC: | akrejcir, bugs, dfediuck, didi, lbopf, nashok, pstehlik, rmartins, rmohr, sbonazzo, stirabos, ylavi |
| Target Milestone: | ovirt-4.1.3 | Keywords: | TestOnly, Triaged |
| Target Release: | 4.1.3 | Flags: | rule-engine:
ovirt-4.1+
rule-engine: exception+ ylavi: planning_ack+ sbonazzo: devel_ack+ pstehlik: testing_ack+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | No Doc Update | |
| Doc Text: |
undefined
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-07-06 14:01:27 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | SLA | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Rafael, can you please update Doc-Text for this bug? (In reply to Sandro Bonazzola from comment #2) > Rafael, can you please update Doc-Text for this bug? I'm moving this back to ASSIGNED and will see if storage guys can help on this *** Bug 1339321 has been marked as a duplicate of this bug. *** (In reply to Rafael Martins from comment #3) > (In reply to Sandro Bonazzola from comment #2) > > Rafael, can you please update Doc-Text for this bug? > > I'm moving this back to ASSIGNED and will see if storage guys can help on > this Any news? Probably the engine has to be fixed as well to correctly detect the disk with json description and one with a simple string for compatibility issues: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineConfigFetcher.java;h=d4accd062c5fe7ad8263b9b3bd28d51d30cb3ad4;hb=HEAD#l124 The effort to modify the engine code to extract the tar file size from the image description is comparable with the effort to extract the tar file size from the tar header so duplicating the info doesn't seam worth. Moving the bug to the engine to have a single fix there. Lets do a quick fix for 4.1 here, just define a fixed size to download (a 100KiB or so should be enough). We will have to adapt to different API for 4.2. The download size is already limited by the configuration value HostedEngineConfigDiskSizeInBytes. By default it is set to 20 KiB. Hi, can you please provide verification steps? Andrej helped me with verification. Verified on ovirt-engine-4.1.3.1-0.1.el7.noarch With the default HostedEngineConfigDiskSizeInBytes of 20480, it can cause issues while validating conf volume archive in RetrieveImageDataVDSCommand . For one of the customer , it's failing with error "received downloaded data size is wrong (requested 20480, received 10240)" while deploying HE using RHV-M.
===
2017-06-30 03:24:18,866 ERROR [org.ovirt.engine.core.vdsbroker.irsbroker.RetrieveImageDataVDSCommand] (ForkJoinPool.commonPool-worker-3) [2707a5e6] Command 'RetrieveImageDataVDSCommand(HostName = =, ImageHttpAccessVDSCommandParameters:{runAsync='true', hostId='949da47b-23c6-4cd1-8509-760f5f9fa316'})' execution failed: VDSGenericException: VDSErrorException: received downloaded data size is wrong (requested 20480, received 10240)
====
We have to manually adjust the HostedEngineConfigDiskSizeInBytes to 10240 to make this work.
Is reading the size from tar header still in consideration ?
I believe conf volume size can vary depending upon the environment and the version where it was created as I can see new conf parameters added in answer.conf and hosted-engine.conf in newer version compared to the conf volume customer is having.
|
Description of problem: The disk images created by the setup, specifically the configuration disk and will be in use to as answer file when deploying hosted engine from the engine. When the engine will download that volume, we need not to download the whole 1GB it takes on the disk but rather the size of the tar image on it. Since we know the size of the tar when we create it, we can put the size in the description, same as what engine does when it serializes OVF into OVF_STORE volumes. example of OVF volume description: {"Updated":true,"Size":10240,"Last Updated":"Wed Apr 20 07:51:46 UTC 2016","Storage Domains":[{"uuid":"fe8f242c-e945-4822-a9f1-ea36d4f56132"}],"Disk Description":"OVF_STORE"}. Once the real size is there, we can use RerieveImageCommand with a Range=0-10240 to download the tar with the hosted-engine.conf inside which is 10KiB instead of 1Gib Actual results: The description is one word - HostedEngineConfigurationImage with no size and other standard parsable structure by engine Expected results: Have the same json structure the engine expects like OVF_STORE in the volume description, specially 'size' . Additional info: