Bug 1336840

Summary:	Prevent import of VMware machines with snapshot
Product:	[oVirt] vdsm	Reporter:	Tomáš Golembiovský <tgolembi>
Component:	General	Assignee:	Sharon Gratch <sgratch>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Nisim Simsolo <nsimsolo>
Severity:	high	Docs Contact:
Priority:	high
Version:	---	CC:	bugs, lveyde, mgoldboi, michal.skrivanek, nsimsolo, sgratch, shavivi, tjelinek
Target Milestone:	ovirt-4.1.2	Flags:	michal.skrivanek: ovirt-4.1? rule-engine: planning_ack? rule-engine: devel_ack+ rule-engine: testing_ack+
Target Release:	4.19.11
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: virt-v2v doesn't support importing of VMs with snapshot(s). The bug was that a user is able to select a VMware VM with snapshot(s) for importing without knowing that this VM has snapshot(s) and the import itself will fail later on during copy disks phase. Consequence: The import of this VM with snapshot(s) fail since it is not supported. Fix: fixing the issue is done by preventing those VMware VMS from being imported (done on VDSM side) and writing an error to VDSM log for notification. Preventing means avoid displaying them in v2v second dialog for importing. In general, we should prevent import with snapshots for all external providers. But since for Xen there is no libvirt API implemented for checking if snapshots exist and for 'OVA from VMware' and KVM - the VM is imported after all snapshots are collapsed, then the only external provider left that may have snapshots to handle is VMware. Result: The user is notified that the selected VM has snapshots and the import is prevented.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-23 08:22:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomáš Golembiovský 2016-05-17 14:36:41 UTC

Description of problem:
The user is able to select VMware machine with snapshosts for import. This is however not supported by virt-v2v and the import will fail. The user should be notified that the selected VM has snapshots and the import should be prevented.

Version-Release number of selected component (if applicable):
oVirt 3.6

How reproducible:
always

Steps to Reproduce:
1. Select 'Virtual Machines' tab and press 'Import'
2. Select 'VMware' as source and fill in the connection information
3. Press 'Load' and from the list of machines select VM with snapshots and import it

Actual results:
The import will end with an error.

Expected results:
The import should be prevented and user has to be told that the VM contains snapshots.

Additional info:

Comment 1 Michal Skrivanek 2016-05-18 05:23:05 UTC

Best would be to grey out the VM names reported with snapshots. This may not make sense with lazy loading, then indeed it should not allow you to continue when such a VM is selected

Comment 2 Tomáš Golembiovský 2016-05-18 10:45:12 UTC

(In reply to Michal Skrivanek from comment #1)
> Best would be to grey out the VM names reported with snapshots.

I aggree. Also it would be worth doing the same thing for the running VMs as noted in: https://bugzilla.redhat.com/show_bug.cgi?id=1296222
Better to grey things out than to hide them IMHO.

> This may not
> make sense with lazy loading, then indeed it should not allow you to
> continue when such a VM is selected

You can give the user the oportunity to select any VM in the first dialog (the one with names) and gray things out (plus prevent the import) in the second dialog (with the details). Then the user can either go back and unselect the VMs in question in the first dialog. Or stop VMs/merge snapshots in vCenter and then press 'Update' button (which we don't have now ;)) in the second dialog to refresh the state in the engine.

Comment 3 Michal Skrivanek 2016-12-14 12:21:37 UTC

let's not track that as RFE, it's a small improvement

Comment 4 Shahar Havivi 2017-01-10 13:59:51 UTC

We do want to remove the filter in vdsm for Block devices on Xen and VMs that we failed to read the disks devices.

Comment 5 Sandro Bonazzola 2017-02-01 16:03:12 UTC

oVirt 4.1.0 GA has been released, re-targeting to 4.1.1.
Please check if this issue is correctly targeted or already included in 4.1.0.

Comment 6 Sharon Gratch 2017-02-02 10:38:18 UTC

It should be targeted to 4.1.1 (it's not included in 4.1.0), thanks.

Comment 8 Nisim Simsolo 2017-04-27 13:05:46 UTC

Verification build:
ovirt-engine-4.1.2-0.1.el7
vdsm-4.19.11-1.el7ev.x86_64
libvirt-client-2.0.0-10.el7_3.5.x86_64
qemu-kvm-rhev-2.6.0-28.el7_3.9.x86_64
sanlock-3.4.0-1.el7.x86_64

Test case changes accordingly (added to external trackers).