Bug 1337222
| Summary: | Please consider managing /etc/resolv.conf not a symlink | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Petr Sklenar <psklenar> |
| Component: | NetworkManager | Assignee: | Thomas Haller <thaller> |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 7.2 | CC: | atragler, bgalvani, jscotka, lrintel, rkhan, thaller, thozza, vbenes, vhumpa |
| Target Milestone: | rc | Keywords: | Regression, TestBlocker |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | NetworkManager-1.2.0-2.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-03 19:10:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1116999, 1342401 | ||
| Bug Blocks: | |||
|
Description
Petr Sklenar
2016-05-18 14:18:39 UTC
there are also issues with our testing environment which is not ready to have this file like a symlink, backuping and restoring stop to work this is already configurable at runtime via main.rc-manager (see `man NetworkManager.conf`). after discussion, it seems the best way to solve this is by changing the compile-time default-value of the configuration option for RHEL. For that, I added a new configure option "--with-config-dns-rc-manager-default", and RHEL-7 packages should be build "--with-config-dns-rc-manager-default=file" How about: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=th%2Fdns-rc-manager-default-rh1337222 (In reply to Thomas Haller from comment #6) > this is already configurable at runtime via main.rc-manager (see `man > NetworkManager.conf`). > > after discussion, it seems the best way to solve this is by changing the > compile-time default-value of the configuration option for RHEL. > > For that, I added a new configure option > "--with-config-dns-rc-manager-default", and RHEL-7 packages should be build > "--with-config-dns-rc-manager-default=file" > > > How about: > https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/ > ?id=th%2Fdns-rc-manager-default-rh1337222 Can't the same result be achieved by installing a configuration snippet in /usr/lib/NetworkManager/conf.d/ ? It looks like a simpler solution to me. And also, allowing different build-time defaults makes it slightly harder to debug and understand the desired behavior (because you need to know how the daemon was compiled)... I thinking about different distributions choosing different defaults. (In reply to Beniamino Galvani from comment #7) > (In reply to Thomas Haller from comment #6) > > this is already configurable at runtime via main.rc-manager (see `man > > NetworkManager.conf`). > > > > after discussion, it seems the best way to solve this is by changing the > > compile-time default-value of the configuration option for RHEL. > > > > For that, I added a new configure option > > "--with-config-dns-rc-manager-default", and RHEL-7 packages should be build > > "--with-config-dns-rc-manager-default=file" > > > > > > How about: > > https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/ > > ?id=th%2Fdns-rc-manager-default-rh1337222 > > Can't the same result be achieved by installing a configuration snippet in > /usr/lib/NetworkManager/conf.d/ ? It looks like a simpler solution to me. > And also, allowing different build-time defaults makes it slightly harder to > debug and understand the desired behavior (because you need to know how the > daemon was compiled)... I thinking about different distributions choosing > different defaults. You are right. Yes, a configuration snippet would have a very similar effect. I think both solutions are very similar, unclear which is better. The main reason I prefer changing the compile-time default is that it avoids reading a configuration file *every* time NM starts on RHEL. No strong reason there... Also, the manual states that the default might differ between distributions -- which is already now the case, e.g. on SUSE the default is netconfig. So, that didn't really change for the worse. +1 for a config-time option; but not that I care too much either, a configuration file would be fine too. ACK for the branch merged to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=51791c4772e7a9c26a1afc088069e9d4d862d36c (still needs backporting) Looks like this breaks selinux policy for the resolv.conf. Perhaps will also require update of that. See: https://beaker.engineering.redhat.com/jobs/1356695 Which contains lots of AVC such as: http://beaker-archive.app.eng.bos.redhat.com/beaker-logs/2016/06/13566/1356695/2765632/41633057/205217065/test_log-NetworkManager_Test5_testcase_290425-avc.log [root@qe-dell-ovs5-vm-23 NetworkManager]# rpm -q NetworkManager NetworkManager-1.2.0-2.el7.x86_64 [root@qe-dell-ovs5-vm-23 NetworkManager]# ls -la /etc/resolv.conf -rw-r--r--. 1 root root 132 Jun 6 08:43 /etc/resolv.conf Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-2581.html |