Bug 1337233
| Summary: | [Ansible Tower] Validation does not work when editing provider | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Pavol Kotvan <pakotvan> |
| Component: | Providers | Assignee: | Brandon Dunne <bdunne> |
| Status: | CLOSED ERRATA | QA Contact: | Pavol Kotvan <pakotvan> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 5.6.0 | CC: | jfrey, jhardy, obarenbo, simaishi |
| Target Milestone: | GA | ||
| Target Release: | 5.6.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | ui:tower | ||
| Fixed In Version: | 5.6.0.9 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-06-29 16:03:56 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | Bug | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Comment 3
CFME Bot
2016-05-19 21:00:53 UTC
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/1ac3595cec4d73a8764cce06958b93e84565a41e commit 1ac3595cec4d73a8764cce06958b93e84565a41e Author: Brandon Dunne <bdunne> AuthorDate: Thu May 19 16:36:12 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Mon May 23 09:53:25 2016 -0400 Exception handling for Provider#verify_credentials belongs in the models https://bugzilla.redhat.com/show_bug.cgi?id=1337233 app/controllers/provider_foreman_controller.rb | 7 +------ app/models/manageiq/providers/ansible_tower/provider.rb | 2 ++ 2 files changed, 3 insertions(+), 6 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/c2527c760a9326e86c7a198a6d951657f75561e6 commit c2527c760a9326e86c7a198a6d951657f75561e6 Author: Brandon Dunne <bdunne> AuthorDate: Thu May 19 16:38:22 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Mon May 23 09:53:25 2016 -0400 Options hash passed in always contained :url, not :base_url https://bugzilla.redhat.com/show_bug.cgi?id=1337233 app/models/manageiq/providers/ansible_tower/provider.rb | 2 +- .../manageiq/providers/ansible_tower/provider_spec.rb | 14 ++++++++------ 2 files changed, 9 insertions(+), 7 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/01b7e9d60047656ca3f7ee4e4fbef6c8adecb56d commit 01b7e9d60047656ca3f7ee4e4fbef6c8adecb56d Author: Brandon Dunne <bdunne> AuthorDate: Thu May 19 16:40:56 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Mon May 23 09:53:25 2016 -0400 Extract finding or building a provider instance to a method https://bugzilla.redhat.com/show_bug.cgi?id=1337233 app/controllers/provider_foreman_controller.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/0da0225f80cb8b98369c7357a1e926a6ddf8d264 commit 0da0225f80cb8b98369c7357a1e926a6ddf8d264 Author: Brandon Dunne <bdunne> AuthorDate: Thu May 19 16:41:48 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Mon May 23 09:53:25 2016 -0400 Extract syncing the form data to the instance https://bugzilla.redhat.com/show_bug.cgi?id=1337233 app/controllers/provider_foreman_controller.rb | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/99cfab261c0d7c30ef36ec5147452a23244ea340 commit 99cfab261c0d7c30ef36ec5147452a23244ea340 Author: Brandon Dunne <bdunne> AuthorDate: Thu May 19 16:46:43 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Mon May 23 09:53:25 2016 -0400 Reuse methods for obtaining a provider object and syncing data from form Fixes issues where data from the form is not used when verifying credentials because the record is reloaded. https://bugzilla.redhat.com/show_bug.cgi?id=1337233 app/controllers/provider_foreman_controller.rb | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/73af855837b381d8072e22b97d3f900a38231fd0 commit 73af855837b381d8072e22b97d3f900a38231fd0 Author: Brandon Dunne <bdunne> AuthorDate: Thu May 19 18:01:46 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Mon May 23 09:53:25 2016 -0400 Don't update the URL when using "=" Use "autosave => true" so that the endpoint is saved on provider save. https://bugzilla.redhat.com/show_bug.cgi?id=1337233 app/models/manageiq/providers/ansible_tower/provider.rb | 2 +- app/models/provider.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1348 |