Bug 1337260

Summary: Bad example in the default smb.conf
Product: [Fedora] Fedora Reporter: Stephen Gallagher <sgallagh>
Component: sambaAssignee: Guenther Deschner <gdeschner>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: abokovoy, asn, gdeschner, jarrpa, jlayton, jlayton, lmohanty, madam, sbose, ssorce
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: samba-4.4.4-3.fc24 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-22 23:53:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to correct example none

Description Stephen Gallagher 2016-05-18 16:05:36 UTC 
Created attachment 1158900 [details]
Patch to correct example

Description of problem:

The "staff" example describes a share that is read-only except for users in the staff group, however the actual implementation included "writable = yes", which makes the share world-writable.


Version-Release number of selected component (if applicable):
samba-4.4.3-1.fc24.x86_64

How reproducible:
Every time

Steps to Reproduce:
1. Read the default smb.conf
2.
3.

Actual results:
The example produces a world-writable share

Expected results:
The example should match its description.

Additional info:

Patch attached.
Comment 1 Andreas Schneider 2016-06-20 07:41:46 UTC 
Well, 'writeable = no' should be set here, but it isn't world writeable until the directory allows write access for others!
Comment 2 Fedora Update System 2016-06-20 11:08:04 UTC 
samba-4.4.4-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe7dd926d5
Comment 3 Fedora Update System 2016-06-20 20:53:56 UTC 
samba-4.4.4-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe7dd926d5
Comment 4 Fedora Update System 2016-06-22 23:53:53 UTC 
samba-4.4.4-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.