Bug 1337834

Summary: MoM completely ignores VMs when they have no ballooning devices
Product: [oVirt] mom Reporter: Roman Mohr <rmohr>
Component: CoreAssignee: Martin Sivák <msivak>
Status: CLOSED CURRENTRELEASE QA Contact: Shira Maximov <mshira>
Severity: high Docs Contact:
Priority: high    
Version: 0.5.1CC: alukiano, bugs, dfediuck, mavital, mgoldboi
Target Milestone: ovirt-3.6.7Flags: dfediuck: ovirt-3.6.z?
dfediuck: ovirt-4.0.0?
mgoldboi: planning_ack+
dfediuck: devel_ack+
mavital: testing_ack+
Target Release: 0.5.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: mom-0.5.4-1 Doc Type: Bug Fix
Doc Text:
Cause: The heritage of MOM did not prepare it well for non-memory related tasks. So any VM without ballooning information was intentionally ignored by MOM. Since MOM now also manages CPU and IO related QoS this was not desirable. Consequence: No CPU and IO QoS values were applies to VMs. Fix: A new data collector (compatibility reasons) was added that marks ballooning information as optional. Result: CPU and IO QoS values are applied when MOM is configured to use the new ballooning collector. Please note that in oVirt this is configured by VDSM.
Story Points: ---
Clone Of:
: 1337882 (view as bug list) Environment:
Last Closed: 2016-07-04 12:33:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1191119, 1337882, 1361553    

Description Roman Mohr 2016-05-20 08:07:04 UTC
Description of problem:

In the past MOM was only responsible for ballooning. But now it also manages some CPU and storage QoS settings. When there is no ballooning device on the VM, MOM completely ignores that VM and therefore does not set QoS attributes for CPU and storage.


Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1) Create a VM with no ballooning device or with
    <memballoon model="none"/>
2) Add QoS attributes through vdsm to the domain XML metadata section


Actual results:
MOM does not apply them and writes to the logs that it ignores the VM because of no ballooning device.

Expected results:
MOM applies QoS attributes to the libvirt domain xml.

Additional info:

Comment 1 Shira Maximov 2016-06-14 08:43:12 UTC
verified on : 
Red Hat Enterprise Virtualization Manager Version: 3.6.7.2-0.1.el6


verification steps: 
1. install mom-0.5.4-1 on the host 
2. create vm with ballooning disabled 
3. check mom logs for : 
"2016-06-13 11:24:48,946 - mom.Monitor - INFO - golden_env_mixed_virtio_0 is ready "

Comment 2 Martin Sivák 2016-06-15 08:51:33 UTC
*** Bug 1278324 has been marked as a duplicate of this bug. ***