Bug 1338007
| Summary: | Automate Method: Loosing value entered in data field when adding input parameters | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Harpreet Kataria <hkataria> | ||||||||
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Matouš Mojžíš <mmojzis> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | 5.5.0 | CC: | cpelland, hkataria, jhardy, mmojzis, mpovolny, obarenbo, simaishi | ||||||||
| Target Milestone: | GA | Keywords: | ZStream | ||||||||
| Target Release: | 5.6.0 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | 5.6.0.8 | Doc Type: | If docs needed, set a value | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | |||||||||||
| : | 1338817 (view as bug list) | Environment: | |||||||||
| Last Closed: | 2016-06-29 16:04:57 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1338817 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Harpreet Kataria
2016-05-20 16:58:35 UTC
Created attachment 1160015 [details]
entered data in method editor
Created attachment 1160016 [details]
method lost in Data field
Created attachment 1160017 [details]
value in data field lost after adding parameter
In In order to save the value in Data fields as a workaround user can first save method with All the values entered in Name, Description, Data etc fields save the record, then Edit the same method again and add Input Parameters, Save the record. New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/bd0dcb2bec3510f85a815d7e0f372822026bcb03 commit bd0dcb2bec3510f85a815d7e0f372822026bcb03 Author: Harpreet Kataria <hkataria> AuthorDate: Fri May 20 14:50:01 2016 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Fri May 20 14:50:01 2016 -0400 Split input parameters in method editor into it's own view. Replacing whole form when adding/removing input parameters in method editor was causing to loose value in Data field on the form due to the fact that data field does not get saved in @edit[:new] until add/save button is pressed due to the large amount of data that can be saved in that field and we don't send the large amount of data up to server every time value is changed in data field on the form. To resolve the issue splitting input_div into it's own view so page replace can be done on that specific div when adding/removing Input parameters to refresh the table in method editor. https://bugzilla.redhat.com/show_bug.cgi?id=1338007 app/controllers/miq_ae_class_controller.rb | 33 ++++-------- app/views/miq_ae_class/_inputs.html.haml | 77 +++++++++++++++++++++++++++ app/views/miq_ae_class/_method_form.html.haml | 76 +------------------------- 3 files changed, 87 insertions(+), 99 deletions(-) create mode 100644 app/views/miq_ae_class/_inputs.html.haml Verified in 5.6.0.8-rc1.20160524155303_f2a5a50. Data were not lost, when I added an input parameter and when I saved method then. New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=cf203a572b793e05215bf1a7ef7844d69fe14a69 commit cf203a572b793e05215bf1a7ef7844d69fe14a69 Author: Harpreet Kataria <hkataria> AuthorDate: Fri May 20 14:50:01 2016 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Mon Jun 13 13:40:02 2016 -0400 Split input parameters in method editor into it's own view. Replacing whole form when adding/removing input parameters in method editor was causing to loose value in Data field on the form due to the fact that data field does not get saved in @edit[:new] until add/save button is pressed due to the large amount of data that can be saved in that field and we don't send the large amount of data up to server every time value is changed in data field on the form. To resolve the issue splitting input_div into it's own view so page replace can be done on that specific div when adding/removing Input parameters to refresh the table in method editor. https://bugzilla.redhat.com/show_bug.cgi?id=1338007 https://bugzilla.redhat.com/show_bug.cgi?id=1338817 app/controllers/miq_ae_class_controller.rb | 37 ++++--------- app/views/miq_ae_class/_inputs.html.haml | 77 +++++++++++++++++++++++++++ app/views/miq_ae_class/_method_form.html.haml | 73 +------------------------ 3 files changed, 89 insertions(+), 98 deletions(-) create mode 100644 app/views/miq_ae_class/_inputs.html.haml New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a39de4d29cde758da8ee3cbda3ea784c89ec89ea commit a39de4d29cde758da8ee3cbda3ea784c89ec89ea Merge: 8269067 cf203a5 Author: Dan Clarizio <dclarizi> AuthorDate: Mon Jun 13 15:11:08 2016 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Mon Jun 13 15:11:08 2016 -0400 Merge branch '55z_pr_8864' into '5.5.z' Split input parameters in method editor into it's own view. Replacing whole form when adding/removing input parameters in method editor was causing to loose value in Data field on the form due to the fact that data field does not get saved in @edit[:new] until add/save button is pressed due to the large amount of data that can be saved in that field and we don't send the large amount of data up to server every time value is changed in data field on the form. To resolve the issue splitting input_div into it's own view so page replace can be done on that specific div when adding/removing Input parameters to refresh the table in method editor. https://bugzilla.redhat.com/show_bug.cgi?id=1338007 https://bugzilla.redhat.com/show_bug.cgi?id=1338817 @dclarizi @chessbyte please review/merge. This is clean cherry-pick for https://github.com/ManageIQ/manageiq/pull/8864 See merge request !948 app/controllers/miq_ae_class_controller.rb | 37 ++++--------- app/views/miq_ae_class/_inputs.html.haml | 77 +++++++++++++++++++++++++++ app/views/miq_ae_class/_method_form.html.haml | 73 +------------------------ 3 files changed, 89 insertions(+), 98 deletions(-) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1348 One time issue. Setting qe_test_coverage flag to -. |