Bug 1338667

Summary: corosync: Handle corosync errors in print_key func (was rhel-osp-director: rhel-osp-director: upgrade 7.3->8.0, that follows update 7.2->7.3, times out during "major-upgrade-pacemaker.yaml" step.)
Product: Red Hat Enterprise Linux 7 Reporter: Marcel Kolaja <mkolaja>
Component: corosyncAssignee: Jan Friesse <jfriesse>
Status: CLOSED ERRATA QA Contact: Leonid Natapov <lnatapov>
Severity: urgent Docs Contact: Marie Hornickova <mdolezel>
Priority: urgent    
Version: 7.2CC: ccaulfie, cluster-maint, dbecker, fdinitto, jfriesse, jruemker, jstransk, lbezdick, mburns, mdolezel, michele, mjuricek, morazi, rhel-osp-director-maint, rscarazz, sasha
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: corosync-2.3.4-7.el7_2.3 Doc Type: Bug Fix
Doc Text:
Previously, the corosync-cmapctl utility did not handle corosync errors in the print_key() function correctly. Consequently, corosync-cmapctl could enter an infinite loop if the corosync utility was killed. The provided fix makes sure all errors returned when corosync exits are handled correctly. As a result, corosync-cmapctl leaves the loop and displays a relevant error message in this scenario.
Story Points: ---
Clone Of: 1336462 Environment:
Last Closed: 2016-06-23 05:38:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1336462    
Bug Blocks:    
Attachments:
Description Flags
7.2.z-bz1338667-1-cmapctl-Handle-corosync-errors-in-print_key-func none

Description Marcel Kolaja 2016-05-23 08:33:09 UTC
This bug has been copied from bug #1336462 and has been proposed
to be backported to 7.2 z-stream (EUS).

Comment 3 Jan Friesse 2016-05-23 14:02:58 UTC
Created attachment 1160643 [details]
7.2.z-bz1338667-1-cmapctl-Handle-corosync-errors-in-print_key-func

cmapctl: Handle corosync errors in print_key func

print_key handles only CS_ERR_TRY_AGAIN error. If different error is
returned, print_key loops forewer.

Solution is to handle all errors.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Christine Caulfield <ccaulfie>

Comment 5 Leonid Natapov 2016-05-26 12:45:07 UTC
corosync-2.3.4-7.el7_2.3
Since Sasha tested this on 7.2 ( deploy 7.2, update to 7.3 , upgrade to 8.0) I have verified that specific code is in the new corosync package. 

root@overcloud-controller-2 rhel-7.2]# pwd
/root/corosync/rhel-7.2

-rw-r--r--.  1 root root   1131 May 25 16:05 bz1338667-1-cmapctl-Handle-corosync-errors-in-print_key-func.patch

Comment 8 errata-xmlrpc 2016-06-23 05:38:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1291