Bug 1339029

Spec file comments:

> %define rpm_name libintelnvm-cim
> %define build_version 1.0.0.1036
> %define build_release 1
> %define dname %{rpm_name}-devel

Delete these variables and just use the values directly.

> Source:         https://github.com/01org/intelnvmcimlibrary/archive/v%{version}.tar.gz

Switch this naming scheme to libintelnvm-cim-%{version}.tar.gz

> %define  debug_package %{nil}

I think you can just delete this.

> %build
> make BUILDNUM=%{build_version} RELEASE=1

This seems to defeat, or otherwise not consider the distro provided compiler flags.

> %defattr(755,root,root,755)

All the usages of defattr in the spec file are either redundant, because rpm can figure it out itself, or broken in the case of the LICENSE file being inadvertently marked executable.

fedora-review reports the following, which all seem to be valid:

libintelnvm-cim.x86_64: W: incoherent-version-in-changelog 1.0.0.1036 ['1.0.0.1036-1.fc24', '1.0.0.1036-1']
libintelnvm-cim.x86_64: W: unstripped-binary-or-object /usr/lib64/libintelnvm-cim.so.1.0.0
libintelnvm-cim.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libintelnvm-cim.so.1.0.0 ['/opt/intel/bin']
libintelnvm-cim.x86_64: W: no-documentation
libintelnvm-cim.x86_64: E: script-without-shebang /usr/share/licenses/libintelnvm-cim/LICENSE
libintelnvm-cim-devel.x86_64: W: only-non-binary-in-usr-lib
libintelnvm-cim-devel.x86_64: W: no-documentation
libintelnvm-cim-devel.x86_64: E: script-without-shebang /usr/share/licenses/libintelnvm-cim-devel/LICENSE

Incorporated feedback - Switched naming scheme, not disabling debug package, removed attr settings, deleted variables, got rid of fedora-review errors. 

Updated URLs - 
Spec URL: https://github.com/01org/intelnvmcimlibrary/releases/download/libintelnvm-cim-1.0.0.1036/libintelnvm-cim.spec

SRPM URL: https://github.com/01org/intelnvmcimlibrary/releases/download/libintelnvm-cim-1.0.0.1036/libintelnvm-cim-1.0.0.1036-1.fc23.src.rpm

Updated spec and tags to have GitHub's auto archiving produce a properly formatted tarball. 

Spec URL: https://github.com/01org/intelnvmcimlibrary/releases/download/v1.0.0.1036/libintelnvm-cim.spec

https://github.com/01org/intelnvmcimlibrary/releases/download/v1.0.0.1036/libintelnvm-cim-1.0.0.1036-1.fc23.src.rpm

Updated spec to comply with Red Hat's open source package policies. 

Spec URL: https://github.com/01org/intelnvmcimlibrary/releases/download/v1.0.0.1039/libinvm-cim.spec

SRPM URL: https://github.com/01org/intelnvmcimlibrary/releases/download/v1.0.0.1039/libinvm-cim-1.0.0.1039-1.fc23.src.rpm

I don't see the redhat optflags in use during the build, for example:

gcc -Wall -Werror -Wfatal-errors -fstack-protector-all -D_FORTIFY_SOURCE=2 -D_XOPEN_SOURCE=500  -fPIC -O2 -std=c99 -MMD -D__VERSION_MAJOR__=1 -D__VERSION_MINOR__=0 -D__VERSION_HOTFIX__=0 -D__VERSION_BUILDNUM__=1039 -D__VERSION_NUMBER__=1.0.0.1039 -D__WBEM_PREFIX__='Intel_' -D__LINUX__ -I./src -I./src/cimom -I./src/framework -I./src/common -I./src/common/logger -I./src/common/string -I./external/rapidxml-1.13 -I./external/cmpi/include -c src/common/string/s_str.c -o output/obj/linux/release/common/string/s_str.o  



Also, fedora-review notes that %{?_smp_mflags} is missing.

Updated the spec to use %{?optflags} and %{?_smp_mflags} during the build.

Renamed the repo to libinvm-cim. 

Spec: https://github.com/01org/libinvm-cim/releases/download/v1.0.0.1039/libinvm-cim.spec

SRPM: https://github.com/01org/libinvm-cim/releases/download/v1.0.0.1039/libinvm-cim-1.0.0.1039-1.fc23.src.rpm

Created a new release v1.0.0.1040.

Spec: https://github.com/01org/libinvm-cim/releases/download/v1.0.0.1040/libinvm-cim.spec

SRPM: https://github.com/01org/libinvm-cim/releases/download/v1.0.0.1040/libinvm-cim-1.0.0.1040-1.fc23.src.rpm

Here's the result of a fedora-review run with the rest of the template filled out: 

===== MUST items =====

C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "Unknown or generated". 10 files have unknown
     license. Detailed output of licensecheck in /home/namu/1339029
     -libinvm-cim/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[-]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libinvm-
     cim-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define build_version
     1.0.0.1040
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: libinvm-cim-1.0.0.1040-1.fc23.x86_64.rpm
          libinvm-cim-devel-1.0.0.1040-1.fc23.x86_64.rpm
          libinvm-cim-debuginfo-1.0.0.1040-1.fc23.x86_64.rpm
          libinvm-cim-1.0.0.1040-1.fc23.src.rpm
libinvm-cim-devel.x86_64: W: only-non-binary-in-usr-lib
4 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (debuginfo)
-------------------
Checking: libinvm-cim-debuginfo-1.0.0.1040-1.fc23.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
libinvm-cim-devel.x86_64: W: only-non-binary-in-usr-lib
3 packages and 0 specfiles checked; 0 errors, 1 warnings.



Requires
--------
libinvm-cim-devel (rpmlib, GLIBC filtered):
    libinvm-cim(x86-64)
    libinvm-cim.so.1()(64bit)

libinvm-cim (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

libinvm-cim-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
libinvm-cim-devel:
    libinvm-cim-devel
    libinvm-cim-devel(x86-64)

libinvm-cim:
    libinvm-cim
    libinvm-cim(x86-64)
    libinvm-cim.so.1()(64bit)

libinvm-cim-debuginfo:
    libinvm-cim-debuginfo
    libinvm-cim-debuginfo(x86-64)



Source checksums
----------------
https://github.com/01org/intelnvmcimlibrary/archive/v1.0.0.1040.tar.gz#/libinvm-cim-1.0.0.1040.tar.gz :
  CHECKSUM(SHA256) this package     : 50ae04010c2ff70b9aabba451f8361d5e4c0c2d5ee9c839408297d6e7ab4c9dc
  CHECKSUM(SHA256) upstream package : 127cf78a1d16ca46dec16c4195d39e0d87da907f5c13fc15692c36903fc7724d
However, diff -r shows no differences


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1339029
Buildroot used: fedora-23-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Looks good to me.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libinvm-cim

I seem to only have access to Fedora 23, and not Rawhide (devel/master) and Fedora24. I'm unable to to a git/fedpkg push - fails with this error: 

remote: FATAL: W refs/heads/master rpms/libinvm-cim nkothapa DENIED by fallthru
remote: error: hook declined to update refs/heads/master
To ssh://nkothapa.org/rpms/libinvm-cim
! [remote rejected] master -> master (hook declined)
error: failed to push some refs to 'ssh://nkothapa.org/rpms/libinvm-cim'